[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Optimize KoXmlReader
From: "Jaroslaw Staniek" <staniek () kde ! org>
Date: 2010-10-27 5:42:19
Message-ID: 20101027054219.21025.85253 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5693/#review8376
-----------------------------------------------------------
trunk/koffice/libs/odf/KoXmlReader.cpp
<http://svn.reviewboard.kde.org/r/5693/#comment8694>
Further small optimization: localName initialization can be moved after=
line 1362.
- Jaroslaw
On 2010-10-27 05:21:45, Thorsten Zachmann wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5693/
> -----------------------------------------------------------
> =
> (Updated 2010-10-27 05:21:45)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> Use the tag instead of the namespace in the hash function. This reduces t=
he number of compares quite a bit as there the data is better distributed.
> =
> Only create prefix and localName when needed.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/libs/odf/KoXmlReader.cpp 1188346 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5693/diff
> =
> =
> Testing
> -------
> =
> Test work as before. Documents load without problems.
> =
> =
> Thanks,
> =
> Thorsten
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5693/">http://svn.reviewboard.kde.org/r/5693/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5693/diff/1/?file=40260#file40260line1366" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/odf/KoXmlReader.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KoXmlNodeData::hasAttribute(const QString& name) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1366</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="n">prefix</span><span class="p">.</span><span \
class="n">isNull</span><span class="p">())</span> <span class="k">return</span><span \
class="p">;</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">1362</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">prefix</span><span class="p">.</span><span \
class="n">isNull</span><span class="p">())</span> <span class="k">return</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Further \
small optimization: localName initialization can be moved after line 1362.</pre> \
</div> <br />
<p>- Jaroslaw</p>
<br />
<p>On October 27th, 2010, 5:21 a.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated 2010-10-27 05:21:45</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use the tag instead of the namespace in the hash function. This reduces \
the number of compares quite a bit as there the data is better distributed.
Only create prefix and localName when needed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Test work as before. Documents load without problems.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/odf/KoXmlReader.cpp <span style="color: \
grey">(1188346)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5693/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic