This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5680/

Ship it!

Looks good. I haven't noticed any problems with it.

- Sven


On October 21st, 2010, 8:58 p.m., Dmitry Kazakov wrote:

Review request for KOffice.
By Dmitry Kazakov.

Updated 2010-10-21 20:58:38

Description

This patch fixes many bugs in shape layers. It consists of two small parts: the first makes KisBaseNode::visible() recursive, the second brings order to KisShapeController.

Need help with testing.
Bugs: 252451, 253766, 254178

Diffs

  • /trunk/koffice/krita/image/kis_base_node.h (1183235)
  • /trunk/koffice/krita/image/kis_base_node.cpp (1183235)
  • /trunk/koffice/krita/image/kis_node.h (1183235)
  • /trunk/koffice/krita/image/kis_node.cpp (1183235)
  • /trunk/koffice/krita/ui/CMakeLists.txt (1183235)
  • /trunk/koffice/krita/ui/canvas/kis_canvas2.cpp (1183235)
  • /trunk/koffice/krita/ui/flake/kis_node_shape.cpp (1183235)
  • /trunk/koffice/krita/ui/flake/kis_shape_controller.h (1183235)
  • /trunk/koffice/krita/ui/flake/kis_shape_controller.cpp (1183235)
  • /trunk/koffice/krita/ui/flake/kis_shape_layer.h (1183235)
  • /trunk/koffice/krita/ui/flake/kis_shape_layer.cc (1183235)
  • /trunk/koffice/krita/ui/flake/kis_shape_selection.h (1183235)
  • /trunk/koffice/krita/ui/tests/kis_shape_controller_test.cpp (1183235)
  • /trunk/koffice/krita/ui/tool/kis_selection_tool_helper.cpp (1183235)

View Diff