--===============0566526377== Content-Type: multipart/alternative; boundary="===============3598886916604221372==" --===============3598886916604221372== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-10-22 11:56:30, Sven Langkamp wrote: > > I noticed that the patch still uses KisShapeLayer::addChild that should= not with the ShapeLayerContainerModel > = > Dmitry Kazakov wrote: > Yeah, they are identical atm. I wanted to deprecate addChild in the n= ext patch. Btw, there is a problem with it: addChild has an optional parame= ter that disables updates and it is used in a single place. I haven't got a= n idea how to workaround it yet. Do you have one? The update check prevented calling setDirty in KisShapeLayerShapePaste. The= re was a problem that the setDirty call created a shared pointer which dele= ted the shape layer when running out of scope. - Sven ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5680/#review8303 ----------------------------------------------------------- On 2010-10-21 20:58:38, Dmitry Kazakov wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5680/ > ----------------------------------------------------------- > = > (Updated 2010-10-21 20:58:38) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > This patch fixes many bugs in shape layers. It consists of two small part= s: the first makes KisBaseNode::visible() recursive, the second brings orde= r to KisShapeController. > = > Need help with testing. > = > = > This addresses bugs 252451, 253766 and 254178. > https://bugs.kde.org/show_bug.cgi?id=3D252451 > https://bugs.kde.org/show_bug.cgi?id=3D253766 > https://bugs.kde.org/show_bug.cgi?id=3D254178 > = > = > Diffs > ----- > = > /trunk/koffice/krita/image/kis_base_node.h 1183235 = > /trunk/koffice/krita/image/kis_base_node.cpp 1183235 = > /trunk/koffice/krita/image/kis_node.h 1183235 = > /trunk/koffice/krita/image/kis_node.cpp 1183235 = > /trunk/koffice/krita/ui/CMakeLists.txt 1183235 = > /trunk/koffice/krita/ui/canvas/kis_canvas2.cpp 1183235 = > /trunk/koffice/krita/ui/flake/kis_node_shape.cpp 1183235 = > /trunk/koffice/krita/ui/flake/kis_shape_controller.h 1183235 = > /trunk/koffice/krita/ui/flake/kis_shape_controller.cpp 1183235 = > /trunk/koffice/krita/ui/flake/kis_shape_layer.h 1183235 = > /trunk/koffice/krita/ui/flake/kis_shape_layer.cc 1183235 = > /trunk/koffice/krita/ui/flake/kis_shape_selection.h 1183235 = > /trunk/koffice/krita/ui/tests/kis_shape_controller_test.cpp 1183235 = > /trunk/koffice/krita/ui/tool/kis_selection_tool_helper.cpp 1183235 = > = > Diff: http://svn.reviewboard.kde.org/r/5680/diff > = > = > Testing > ------- > = > = > Thanks, > = > Dmitry > = > --===============3598886916604221372== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5680/

On October 22nd, 2010, 11:56 a.m., Sven Lan= gkamp wrote:

I noticed=
 that the patch still uses KisShapeLayer::addChild that should not with the=
 ShapeLayerContainerModel

On October 22nd, 2010, 2:55 p.m., Dmitry Kazakov wrote:

Yeah, the=
y are identical atm. I wanted to deprecate addChild in the next patch. Btw,=
 there is a problem with it: addChild has an optional parameter that disabl=
es updates and it is used in a single place. I haven't got an idea how =
to workaround it yet. Do you have one?

The update =
check prevented calling setDirty in KisShapeLayerShapePaste. There was a pr=
oblem that the setDirty call created a shared pointer which deleted the sha=
pe layer when running out of scope.

- Sven

On October 21st, 2010, 8:58 p.m., Dmitry Kazakov wrote:

Review request for KOffice.

By Dmitry Kazakov.

Updated 2010-10-21 20:58:38

Descripti= on

This patch fixes many bugs in shape layers. It consists of t=
wo small parts: the first makes KisBaseNode::visible() recursive, the secon=
d brings order to KisShapeController.

Need help with testing.

Bugs: 252451, = 253766, = 254178

Diffs=

/trunk/koffice/krita/image/kis_base_node.h (1183235)
/trunk/koffice/krita/image/kis_base_node.cpp (1183235)
/trunk/koffice/krita/image/kis_node.h (118= 3235)
/trunk/koffice/krita/image/kis_node.cpp (1= 183235)
/trunk/koffice/krita/ui/CMakeLists.txt (11= 83235)
/trunk/koffice/krita/ui/canvas/kis_canvas2.cpp (1183235)
/trunk/koffice/krita/ui/flake/kis_node_shape.cpp (1183235)
/trunk/koffice/krita/ui/flake/kis_shape_controller.h (1183235)
/trunk/koffice/krita/ui/flake/kis_shape_controller.cpp (1183235)
/trunk/koffice/krita/ui/flake/kis_shape_layer.h (1183235)
/trunk/koffice/krita/ui/flake/kis_shape_layer.cc (1183235)
/trunk/koffice/krita/ui/flake/kis_shape_selection.h (1183235)
/trunk/koffice/krita/ui/tests/kis_shape_controller_test.cpp (1183235)
/trunk/koffice/krita/ui/tool/kis_selection_tool_helper.cpp (1183235)

--===============3598886916604221372==-- --===============0566526377== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0566526377==--