This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5680/

On October 22nd, 2010, 11:56 a.m., Sven Langkamp wrote:

I noticed that the patch still uses KisShapeLayer::addChild that should not with the ShapeLayerContainerModel

On October 22nd, 2010, 2:55 p.m., Dmitry Kazakov wrote:

Yeah, they are identical atm. I wanted to deprecate addChild in the next patch. Btw, there is a problem with it: addChild has an optional parameter that disables updates and it is used in a single place. I haven't got an idea how to workaround it yet. Do you have one?

The update check prevented calling setDirty in KisShapeLayerShapePaste. There was a problem that the setDirty call created a shared pointer which deleted the shape layer when running out of scope.

- Sven

On October 21st, 2010, 8:58 p.m., Dmitry Kazakov wrote:

Review request for KOffice.

By Dmitry Kazakov.

Updated 2010-10-21 20:58:38

Description

This patch fixes many bugs in shape layers. It consists of two small parts: the first makes KisBaseNode::visible() recursive, the second brings order to KisShapeController.

Need help with testing.

Bugs: 252451, 253766, 254178

Diffs

/trunk/koffice/krita/image/kis_base_node.h (1183235)
/trunk/koffice/krita/image/kis_base_node.cpp (1183235)
/trunk/koffice/krita/image/kis_node.h (1183235)
/trunk/koffice/krita/image/kis_node.cpp (1183235)
/trunk/koffice/krita/ui/CMakeLists.txt (1183235)
/trunk/koffice/krita/ui/canvas/kis_canvas2.cpp (1183235)
/trunk/koffice/krita/ui/flake/kis_node_shape.cpp (1183235)
/trunk/koffice/krita/ui/flake/kis_shape_controller.h (1183235)
/trunk/koffice/krita/ui/flake/kis_shape_controller.cpp (1183235)
/trunk/koffice/krita/ui/flake/kis_shape_layer.h (1183235)
/trunk/koffice/krita/ui/flake/kis_shape_layer.cc (1183235)
/trunk/koffice/krita/ui/flake/kis_shape_selection.h (1183235)
/trunk/koffice/krita/ui/tests/kis_shape_controller_test.cpp (1183235)
/trunk/koffice/krita/ui/tool/kis_selection_tool_helper.cpp (1183235)

View Diff