--===============2079304996== Content-Type: multipart/alternative; boundary="===============2715097850831297328==" --===============2715097850831297328== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-10-20 15:41:46, Thomas Zander wrote: > > The requested feature is already available in the text tool the request= to be able to click on links in kpresenters presentation tool should follo= w the same design if it wants to do the same thing. > > Making this into an action sounds wrong to me because that means the fu= nctionality becomes available for all tools and that goes against the conce= pt of flake which is that tools are specialized by the functionality that t= he user wants the work with at this moment. > = > Matus Hanzes wrote: > One problem with the TextTool is that I don't want to have IBeamCurso= r when mouse pointer is hovering over text in text shape. > = > Another problem is that I want to handle all mouse events in kpresent= er when the mouse is over TextShape but not over hyperlink.(go to the next = slide) And it is not possible because I can't get the information out of th= e TextTool. > = > If you know how to get the information that mouse pointer is over hyp= erlink out of TextShape. Then tell me. > = > Sorry if I was not clear; I didn't mean you should use the text tool, I sai= d the presentation tools should use the same design that the text tool alre= ady uses. What I meant with that is because both the presentation tool and the text t= ool should handle urls, but no other tools should handle URLS those two too= ls should have code for this behavior. So please add some code to the presentation tool to check if there is a tex= t shape where the user clicked and then use the public APIs to figure out t= he URL and handle that accordingly. How does that sound? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5633/#review8273 ----------------------------------------------------------- On 2010-10-15 14:40:48, Matus Hanzes wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5633/ > ----------------------------------------------------------- > = > (Updated 2010-10-15 14:40:48) > = > = > Review request for KOffice, Thorsten Zachmann and Thomas Zander. > = > = > Summary > ------- > = > Support for hyperlinks in presentation mode consist of two problems > 1. Change the cursor from ArrowCursor to PointingHandCursur, when the cur= sor is over the hyperlink. > 2. Run the hyperlink, when the hyperlink is clicked. > = > I have used KoShape EventAction framework for accessing the data inside T= extShape. > To work with hyperlinks in TextEvenAction I have used code from TextTool. > = > I will do unit tests after this solution is approved. > = > = > Diffs > ----- > = > trunk/koffice/kpresenter/part/KPrPresentationTool.cpp 1186176 = > trunk/koffice/kpresenter/plugins/eventactions/sound/KPrSoundEventAction= .h 1186176 = > trunk/koffice/kpresenter/plugins/eventactions/sound/KPrSoundEventAction= .cpp 1186176 = > trunk/koffice/libs/flake/KoEventAction.h 1186176 = > trunk/koffice/plugins/textshape/CMakeLists.txt 1186176 = > trunk/koffice/plugins/textshape/TextEventAction.h PRE-CREATION = > trunk/koffice/plugins/textshape/TextEventAction.cpp PRE-CREATION = > trunk/koffice/plugins/textshape/TextShape.h 1186176 = > trunk/koffice/plugins/textshape/TextShape.cpp 1186176 = > trunk/koffice/plugins/textshape/tests/CMakeLists.txt 1186176 = > trunk/koffice/plugins/videoshape/VideoEventAction.h 1186176 = > trunk/koffice/plugins/videoshape/VideoEventAction.cpp 1186176 = > = > Diff: http://svn.reviewboard.kde.org/r/5633/diff > = > = > Testing > ------- > = > = > Thanks, > = > Matus > = > --===============2715097850831297328== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5633/ |
On October 20th, 2010, 3:41 p.m., Thomas Za= nder wrote:
The reque= sted feature is already available in the text tool the request to be able t= o click on links in kpresenters presentation tool should follow the same de= sign if it wants to do the same thing. Making this into an action sounds wrong to me because that means the functi= onality becomes available for all tools and that goes against the concept o= f flake which is that tools are specialized by the functionality that the u= ser wants the work with at this moment.On October 21st, 2010, 6:45 a.m., Matus Hanzes wrote:
One probl= em with the TextTool is that I don't want to have IBeamCursor when mous= e pointer is hovering over text in text shape. Another problem is that I want to handle all mouse events in kpresenter whe= n the mouse is over TextShape but not over hyperlink.(go to the next slide)= And it is not possible because I can't get the information out of the = TextTool. If you know how to get the information that mouse pointer is over hyperlink= out of TextShape. Then tell me.
Sorry if I = was not clear; I didn't mean you should use the text tool, I said the p= resentation tools should use the same design that the text tool already use= s. What I meant with that is because both the presentation tool and the text t= ool should handle urls, but no other tools should handle URLS those two too= ls should have code for this behavior. So please add some code to the presentation tool to check if there is a tex= t shape where the user clicked and then use the public APIs to figure out t= he URL and handle that accordingly. How does that sound?
- Thomas
On October 15th, 2010, 2:40 p.m., Matus Hanzes wrote:
Review request for KOffice, Thorsten Zachmann and Thomas Zander.
By Matus Hanzes.
Updated 2010-10-15 14:40:48 Descripti= on
Diffs=
|