From koffice-devel Fri Oct 22 09:24:05 2010 From: "Boudewijn Rempt" Date: Fri, 22 Oct 2010 09:24:05 +0000 To: koffice-devel Subject: Re: Review Request: read application default style only onces Message-Id: <20101022092405.10635.83855 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128774055516928 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1668874904==" --===============1668874904== Content-Type: multipart/alternative; boundary="===============6578755382311027456==" --===============6578755382311027456== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5668/#review8298 ----------------------------------------------------------- Ship it! still ship it :-) - Boudewijn On 2010-10-20 13:26:47, Thorsten Zachmann wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5668/ > ----------------------------------------------------------- > = > (Updated 2010-10-20 13:26:47) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > The attached patch reads the application default style only onces and the= n stores it in the KoTextSharedLoadingData so that it can be reused during = loading of the document. = > = > Before this change the default style was parsed every time KoCharacterSty= le was loaded. > = > = > Diffs > ----- > = > trunk/koffice/kword/part/KWPageStyle.h 1186972 = > trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h 118697= 2 = > trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp 1186= 972 = > trunk/koffice/libs/kotext/styles/KoCharacterStyle.h 1186972 = > trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp 1186972 = > trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1186972 = > trunk/koffice/plugins/chartshape/Axis.cpp 1186972 = > = > Diff: http://svn.reviewboard.kde.org/r/5668/diff > = > = > Testing > ------- > = > = > Thanks, > = > Thorsten > = > --===============6578755382311027456== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5668/

Ship it!

still ship=
 it :-)

- Boudewijn

On October 20th, 2010, 1:26 p.m., Thorsten Zachmann wrote:

Review request for KOffice.

By Thorsten Zachmann.

Updated 2010-10-20 13:26:47

Descripti= on

The attached patch reads the application default style only =
onces and then stores it in the KoTextSharedLoadingData so that it can be r=
eused during loading of the document. =


Before this change the default style was parsed every time KoCharacterStyle=
 was loaded.

Diffs=

trunk/koffice/kword/part/KWPageStyle.h (11= 86972)
trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h (1186972)
trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp (1186972)
trunk/koffice/libs/kotext/styles/KoCharacterStyle.h (1186972)
trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp (1186972)
trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp (1186972)
trunk/koffice/plugins/chartshape/Axis.cpp = (1186972)

--===============6578755382311027456==-- --===============1668874904== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1668874904==--