--===============1895874279== Content-Type: multipart/alternative; boundary="===============6038329753310557679==" --===============6038329753310557679== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5669/#review8299 ----------------------------------------------------------- Ship it! Still ship it. - Boudewijn On 2010-10-20 13:33:29, Thorsten Zachmann wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5669/ > ----------------------------------------------------------- > = > (Updated 2010-10-20 13:33:29) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Use const QString & instead of const char * as parameters. This reduces t= he number of conversions as the string is now converted only once and not e= very time a function is called from within. > = > Also use attributeNS directly without checking if the attribute is there. > = > = > Diffs > ----- > = > trunk/koffice/libs/odf/KoStyleStack.h 1186972 = > trunk/koffice/libs/odf/KoStyleStack.cpp 1186972 = > = > Diff: http://svn.reviewboard.kde.org/r/5669/diff > = > = > Testing > ------- > = > No functionality has changed and it works as it did before the change onl= y faster > = > = > Thanks, > = > Thorsten > = > --===============6038329753310557679== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5669/

Ship it!

Still ship=
 it.

- Boudewijn


On October 20th, 2010, 1:33 p.m., Thorsten Zachmann wrote:

Review request for KOffice.
By Thorsten Zachmann.

Updated 2010-10-20 13:33:29

Descripti= on 

Use const QString & instead of const char * as parameter=
s. This reduces the number of conversions as the string is now converted on=
ly once and not every time a function is called from within.

Also use attributeNS directly without checking if the attribute is there.

Testing <= /h1> 
No functionality has changed and it works as it did before t=
he change only faster

Diffs=

  • trunk/koffice/libs/odf/KoStyleStack.h (118= 6972)
  • trunk/koffice/libs/odf/KoStyleStack.cpp (1= 186972)

View Diff
--===============6038329753310557679==-- --===============1895874279== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1895874279==--