This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5669/

Ship it!

Still ship it.

- Boudewijn


On October 20th, 2010, 1:33 p.m., Thorsten Zachmann wrote:

Review request for KOffice.
By Thorsten Zachmann.

Updated 2010-10-20 13:33:29

Description

Use const QString & instead of const char * as parameters. This reduces the number of conversions as the string is now converted only once and not every time a function is called from within.

Also use attributeNS directly without checking if the attribute is there.

Testing

No functionality has changed and it works as it did before the change only faster

Diffs

  • trunk/koffice/libs/odf/KoStyleStack.h (1186972)
  • trunk/koffice/libs/odf/KoStyleStack.cpp (1186972)

View Diff