[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: A small patch for Krita shape layers :)
From: "Dmitry Kazakov" <dimula73 () gmail ! com>
Date: 2010-10-21 20:58:38
Message-ID: 20101021205838.26336.72529 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5680/
-----------------------------------------------------------
(Updated 2010-10-21 20:58:38.660139)
Review request for KOffice.
Changes
-------
Fixed unit-test
Summary
-------
This patch fixes many bugs in shape layers. It consists of two small parts: the first \
makes KisBaseNode::visible() recursive, the second brings order to \
KisShapeController.
Need help with testing.
This addresses bugs 252451, 253766 and 254178.
https://bugs.kde.org/show_bug.cgi?id=252451
https://bugs.kde.org/show_bug.cgi?id=253766
https://bugs.kde.org/show_bug.cgi?id=254178
Diffs (updated)
-----
/trunk/koffice/krita/image/kis_base_node.h 1183235
/trunk/koffice/krita/image/kis_base_node.cpp 1183235
/trunk/koffice/krita/image/kis_node.h 1183235
/trunk/koffice/krita/image/kis_node.cpp 1183235
/trunk/koffice/krita/ui/CMakeLists.txt 1183235
/trunk/koffice/krita/ui/canvas/kis_canvas2.cpp 1183235
/trunk/koffice/krita/ui/flake/kis_node_shape.cpp 1183235
/trunk/koffice/krita/ui/flake/kis_shape_controller.h 1183235
/trunk/koffice/krita/ui/flake/kis_shape_controller.cpp 1183235
/trunk/koffice/krita/ui/flake/kis_shape_layer.h 1183235
/trunk/koffice/krita/ui/flake/kis_shape_layer.cc 1183235
/trunk/koffice/krita/ui/flake/kis_shape_selection.h 1183235
/trunk/koffice/krita/ui/tests/kis_shape_controller_test.cpp 1183235
/trunk/koffice/krita/ui/tool/kis_selection_tool_helper.cpp 1183235
Diff: http://svn.reviewboard.kde.org/r/5680/diff
Testing
-------
Thanks,
Dmitry
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5680/">http://svn.reviewboard.kde.org/r/5680/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Dmitry Kazakov.</div>
<p style="color: grey;"><i>Updated 2010-10-21 20:58:38.660139</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed unit-test</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes many bugs in shape layers. It consists of two small \
parts: the first makes KisBaseNode::visible() recursive, the second brings order to \
KisShapeController.
Need help with testing.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=252451">252451</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=253766">253766</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=254178">254178</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/krita/image/kis_base_node.h <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/image/kis_base_node.cpp <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/image/kis_node.h <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/image/kis_node.cpp <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/ui/CMakeLists.txt <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/ui/canvas/kis_canvas2.cpp <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/ui/flake/kis_node_shape.cpp <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/ui/flake/kis_shape_controller.h <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/ui/flake/kis_shape_controller.cpp <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/ui/flake/kis_shape_layer.h <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/ui/flake/kis_shape_layer.cc <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/ui/flake/kis_shape_selection.h <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/ui/tests/kis_shape_controller_test.cpp <span style="color: \
grey">(1183235)</span></li>
<li>/trunk/koffice/krita/ui/tool/kis_selection_tool_helper.cpp <span style="color: \
grey">(1183235)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5680/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic