--===============2065285335== Content-Type: multipart/alternative; boundary="===============2047292829980588892==" --===============2047292829980588892== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-10-16 04:41:09, Thorsten Zachmann wrote: > > /trunk/koffice/kpresenter/part/KPrPdfPrintJob.h, line 30 > > > > > > It might be a good idea to inherit KoPAPrintJob and try to share as= much code as possible between this two classes. = > > = > > The KPrPdfPrintJob misses the KoPAPageProvider that is needed to ge= t the page number correct. You can have a look at KoPAPageProvider on how i= t is used. > = > Benjamin Port wrote: > Ok, I'll going to use KoPAPageProvider for page number. > However I'm not sure it's a good idea to inherits KoPAPrintJob becaus= e code it's different. And attribute like KoPAPageProvider were private in = KoPAPrintJob It is fine with me to make the KoPAPageProvider protected. That is preferre= d instead of having a lot of duplicate code and makes it more maintainable. > On 2010-10-16 04:41:09, Thorsten Zachmann wrote: > > /trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp, line 68 > > > > > > Is that is what is wanted when exporting a file to pdf. Don't the u= ser want to set the size of the paper to use and then put the content as bi= g as possible centered on the page? > > = > > Otherwise there might be strange page sizes which has nothing to do= with real page sizes. > = > Thomas Zander wrote: > The point of setting the size of the paper first is forced when you p= rint to paper, obviously you can't change paper size. > On the other hand when printing to PDF there are multiple usecases an= d using the slide's size makes a lot of sense for various usecases. Like f= or example when using a PDF viewer to actually present. > = > So when creating a PDF I think Benjamin is right. We should not forg= et about the people printing to a real printer but in my personal opinion t= hat usecase is reserved for a feature like 'create handouts'. > = > Benjamin Port wrote: > For me the task to put the content as big as possible is done by the = pdf reader tool. > I think export pdf is an easy to use functionnality to allow user to = have presentation at pdf format. So for me the good way to do this is not t= o have a real paper size, but to have a paper size like slide size. > And if someone want to print as pdf with custom size, imo the good wa= y is to use the print task and redirect printer to pdf file, so user can se= lect paper size... It is your call. Thanks for the clarification. - Thorsten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5610/#review8176 ----------------------------------------------------------- On 2010-10-12 16:41:11, Benjamin Port wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5610/ > ----------------------------------------------------------- > = > (Updated 2010-10-12 16:41:11) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > BUG:241245 > This patch correct the bug 214245, when we export to pdf in KPresenter, n= ow the page size is slide size. > With the new methods to export to pdf, each KOffice application can choos= e to kept the old export feature (just print), or implement a specific oper= ation for export pdf. > = > = > Diffs > ----- > = > /trunk/koffice/kpresenter/part/CMakeLists.txt 1185156 = > /trunk/koffice/kpresenter/part/KPrPdfPrintJob.h PRE-CREATION = > /trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp PRE-CREATION = > /trunk/koffice/kpresenter/part/KPrView.h 1185156 = > /trunk/koffice/kpresenter/part/KPrView.cpp 1185156 = > /trunk/koffice/libs/main/KoMainWindow.cpp 1185156 = > /trunk/koffice/libs/main/KoView.h 1185156 = > /trunk/koffice/libs/main/KoView.cpp 1185156 = > = > Diff: http://svn.reviewboard.kde.org/r/5610/diff > = > = > Testing > ------- > = > = > Thanks, > = > Benjamin > = > --===============2047292829980588892== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5610/

On October 16th, 2010, 4:41 a.m., Thorsten = Zachmann wrote:

= = =
/trunk/koffice/kpresenter/part/KPrPdfPrintJob.h (Diff revision 2) 

   
class KoPAPageBase;


  

 

  

    
    

    30
    
class KPrPdfPrintJob : publi=
c KoPrintJob

  


 




  
It might =
be a good idea to inherit KoPAPrintJob and try to share as much code as pos=
sible between this two classes. =


The KPrPdfPrintJob misses the KoPAPageProvider that is needed to get the pa=
ge number correct. You can have a look at KoPAPageProvider on how it is use=
d. 

 




 
On October 16th, 2010, 5:37 p.m., Benjamin Port wrote:

 

  
Ok, I'=
;ll going to use KoPAPageProvider for page number.
However I'm not sure it's a good idea to inherits KoPAPrintJob beca=
use code it's different. And attribute like KoPAPageProvider were priva=
te in KoPAPrintJob

 











It is fine with me to make the KoPAPageProvider protected. That is p=
referred instead of having a lot of duplicate code and makes it more mainta=
inable.






 
On October 16th, 2010, 4:41 a.m., Thorsten =
Zachmann wrote:

 

  =









 =

 =




 

 
  

   
    /trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp
    

     (Diff revision 2)

    
   
  

 

 
  


   

   
void KPrPdfPrintJob::startPrinting(RemovePolicy removePolicy)
=


  

 

  

    
    

    68
    
        m_printer.setPaperSize(QSizeF(layout.width,layout.height),QPrinter::Mi=
llimeter);

  


 




  
Is that i=
s what is wanted when exporting a file to pdf. Don't the user want to s=
et the size of the paper to use and then put the content as big as possible=
 centered on the page?

Otherwise there might be strange page sizes which has nothing to do with re=
al page sizes.

 




 
On October 16th, 2010, 2:25 p.m., Thomas Zander wrote:

 

  
The point=
 of setting the size of the paper first is forced when you print to paper, =
obviously you can't change paper size.
On the other hand when printing to PDF there are multiple usecases and usin=
g the slide's size makes a lot of sense for various usecases.  Like for=
 example when using a PDF viewer to actually present.

So when creating a PDF I think Benjamin is right.  We should not forget abo=
ut the people printing to a real printer but in my personal opinion that us=
ecase is reserved for a feature like 'create handouts'.

 






 
On October 16th, 2010, 5:30 p.m., Benjamin Port wrote:

 

  
For me th=
e task to put the content as big as possible is done by the pdf reader tool.
I think export pdf is an easy to use functionnality to allow user to have p=
resentation at pdf format. So for me the good way to do this is not to have=
 a real paper size, but to have a paper size like slide size.
And if someone want to print as pdf with custom size, imo the good way is t=
o use the print task and redirect printer to pdf file, so user can select p=
aper size...

 











It is your call. Thanks for the clarification.








- Thorsten






On October 12th, 2010, 4:41 p.m., Benjamin Port wrote:









 

  


Review request for KOffice.


By Benjamin Port.




Updated 2010-10-12 16:41:11






Descripti=
on 



 

  
   
BUG:241245
This patch correct the bug 214245, when we export to pdf in KPresenter, now=
 the page size is slide size.
With the new methods to export to pdf, each KOffice application can choose =
to kept the old export feature (just print), or implement a specific operat=
ion for export pdf.

  		
 









Diffs=
 


    

 
  • /trunk/koffice/kpresenter/part/CMakeLists.txt (1185156)
    • 

 
  • /trunk/koffice/kpresenter/part/KPrPdfPrintJob.h (PRE-CREATION)
    • 

 
  • /trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp (PRE-CREATION)
    • 

 
  • /trunk/koffice/kpresenter/part/KPrView.h (=
1185156)
    • 

 
  • /trunk/koffice/kpresenter/part/KPrView.cpp (1185156)
    • 

 
  • /trunk/koffice/libs/main/KoMainWindow.cpp =
(1185156)
    • 

 
  • /trunk/koffice/libs/main/KoView.h (1185156=
)
    • 

 
  • /trunk/koffice/libs/main/KoView.cpp (11851=
56)
    • 





View Diff





  		
 











  

 



--===============2047292829980588892==--

--===============2065285335==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============2065285335==--