[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: read application default style only onces
From: "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date: 2010-10-20 13:26:47
Message-ID: 20101020132647.19317.21529 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5668/
-----------------------------------------------------------
(Updated 2010-10-20 13:26:47.417891)
Review request for KOffice.
Changes
-------
Renamed scontext to shapeContext as proposed by jstaniek
Summary
-------
The attached patch reads the application default style only onces and then =
stores it in the KoTextSharedLoadingData so that it can be reused during lo=
ading of the document. =
Before this change the default style was parsed every time KoCharacterStyle=
was loaded.
Diffs (updated)
-----
trunk/koffice/kword/part/KWPageStyle.h 1186972 =
trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h 1186972 =
trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp 118697=
2 =
trunk/koffice/libs/kotext/styles/KoCharacterStyle.h 1186972 =
trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp 1186972 =
trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1186972 =
trunk/koffice/plugins/chartshape/Axis.cpp 1186972 =
Diff: http://svn.reviewboard.kde.org/r/5668/diff
Testing
-------
Thanks,
Thorsten
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5668/">http://svn.reviewboard.kde.org/r/5668/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated 2010-10-20 13:26:47.417891</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Renamed scontext to shapeContext as proposed by jstaniek</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch reads the application default style only onces and \
then stores it in the KoTextSharedLoadingData so that it can be reused during loading \
of the document.
Before this change the default style was parsed every time KoCharacterStyle was \
loaded.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/kword/part/KWPageStyle.h <span style="color: \
grey">(1186972)</span></li>
<li>trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h <span \
style="color: grey">(1186972)</span></li>
<li>trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp <span \
style="color: grey">(1186972)</span></li>
<li>trunk/koffice/libs/kotext/styles/KoCharacterStyle.h <span style="color: \
grey">(1186972)</span></li>
<li>trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp <span style="color: \
grey">(1186972)</span></li>
<li>trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp <span style="color: \
grey">(1186972)</span></li>
<li>trunk/koffice/plugins/chartshape/Axis.cpp <span style="color: \
grey">(1186972)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5668/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic