[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: read application default style only onces
From: "Jaroslaw Staniek" <staniek () kde ! org>
Date: 2010-10-20 10:15:15
Message-ID: 20101020101515.10755.30296 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5668/#review8258
-----------------------------------------------------------
trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp
<http://svn.reviewboard.kde.org/r/5668/#comment8542>
I propose to use shapeContext name not scontext - less error prone
- Jaroslaw
On 2010-10-20 09:52:05, Thorsten Zachmann wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5668/
> -----------------------------------------------------------
> =
> (Updated 2010-10-20 09:52:05)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> The attached patch reads the application default style only onces and the=
n stores it in the KoTextSharedLoadingData so that it can be reused during =
loading of the document. =
> =
> Before this change the default style was parsed every time KoCharacterSty=
le was loaded.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/kword/part/KWPageStyle.h 1186972 =
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h 118697=
2 =
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp 1186=
972 =
> trunk/koffice/libs/kotext/styles/KoCharacterStyle.h 1186972 =
> trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp 1186972 =
> trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp 1186972 =
> trunk/koffice/plugins/chartshape/Axis.cpp 1186972 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5668/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Thorsten
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5668/">http://svn.reviewboard.kde.org/r/5668/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5668/diff/1/?file=39767#file39767line125" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KoTextSharedLoadingData::addDefaultParagraphStyle(KoShapeLoadingContext &context, \
const KoXmlElement *styleElem, const KoXmlElement *appDefault, KoStyleManager \
*styleManager)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">119</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">addCharacterStyles</span><span class="p">(</span><span \
class="n">context</span><span class="p">,</span> <span class="n">context</span><span \
class="p">.</span><span class="n">stylesReader</span><span class="p">().</span><span \
class="n">autoStyles</span><span class="p">(</span><span \
class="s">"text"</span><span class="p">).</span><span \
class="n">values</span><span class="p">(),</span> <span \
class="n">ContentDotXml</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">125</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">addCharacterStyles</span><span class="p">(</span><span class="n"><span \
class="hl">s</span>context</span><span class="p">,</span> <span \
class="n">context</span><span class="p">.</span><span \
class="n">stylesReader</span><span class="p">().</span><span \
class="n">autoStyles</span><span class="p">(</span><span \
class="s">"text"</span><span class="p">).</span><span \
class="n">values</span><span class="p">(),</span> <span \
class="n">ContentDotXml</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I propose \
to use shapeContext name not scontext - less error prone</pre> </div>
<br />
<p>- Jaroslaw</p>
<br />
<p>On October 20th, 2010, 9:52 a.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated 2010-10-20 09:52:05</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch reads the application default style only onces and \
then stores it in the KoTextSharedLoadingData so that it can be reused during loading \
of the document.
Before this change the default style was parsed every time KoCharacterStyle was \
loaded.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/kword/part/KWPageStyle.h <span style="color: \
grey">(1186972)</span></li>
<li>trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h <span \
style="color: grey">(1186972)</span></li>
<li>trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp <span \
style="color: grey">(1186972)</span></li>
<li>trunk/koffice/libs/kotext/styles/KoCharacterStyle.h <span style="color: \
grey">(1186972)</span></li>
<li>trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp <span style="color: \
grey">(1186972)</span></li>
<li>trunk/koffice/libs/kotext/styles/KoParagraphStyle.cpp <span style="color: \
grey">(1186972)</span></li>
<li>trunk/koffice/plugins/chartshape/Axis.cpp <span style="color: \
grey">(1186972)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5668/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic