[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Optimize KoStyleStack
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2010-10-20 10:07:21
Message-ID: 20101020100721.10472.3219 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5669/#review8256
-----------------------------------------------------------
I was wondering about this one point;
trunk/koffice/libs/odf/KoStyleStack.h
<http://svn.reviewboard.kde.org/r/5669/#comment8539>
Just curious -- why is the detail parameter still const char*
- Boudewijn
On 2010-10-20 10:01:01, Thorsten Zachmann wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5669/
> -----------------------------------------------------------
> =
> (Updated 2010-10-20 10:01:01)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> Use const QString & instead of const char * as parameters. This reduces t=
he number of conversions as the string is now converted only once and not e=
very time a function is called from within.
> =
> Also use attributeNS directly without checking if the attribute is there.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/libs/odf/KoStyleStack.h 1186972 =
> trunk/koffice/libs/odf/KoStyleStack.cpp 1186972 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5669/diff
> =
> =
> Testing
> -------
> =
> No functionality has changed and it works as it did before the change onl=
y faster
> =
> =
> Thanks,
> =
> Thorsten
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5669/">http://svn.reviewboard.kde.org/r/5669/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was wondering about \
this one point;</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5669/diff/1/?file=39773#file39773line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/odf/KoStyleStack.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">103</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">bool</span> <span class="n">hasProperty</span><span class="p">(</span><span \
class="k">const</span> <span class="kt"><span class="hl">char</span></span><span \
class="o"><span class="hl">*</span></span><span class="hl"> </span><span \
class="n">nsURI</span><span class="p">,</span> <span class="k">const</span> <span \
class="kt"><span class="hl">char</span></span><span class="o"><span \
class="hl">*</span></span><span class="hl"> </span><span \
class="n">localName</span><span class="p">,</span> <span class="k">const</span> <span \
class="kt">char</span><span class="o">*</span> <span class="n">detail</span> <span \
class="o">=</span> <span class="mi">0</span><span class="p">)</span> <span \
class="k">const</span><span class="p">;</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">103</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">bool</span> <span class="n">hasProperty</span><span class="p">(</span><span \
class="k">const</span> <span class="n"><span class="hl">QString</span></span><span \
class="hl"> </span><span class="o"><span class="hl">&</span></span><span \
class="n">nsURI</span><span class="p">,</span> <span class="k">const</span> <span \
class="n"><span class="hl">QString</span></span><span class="hl"> </span><span \
class="o"><span class="hl">&</span></span><span class="n">localName</span><span \
class="p">,</span> <span class="k">const</span> <span class="kt">char</span><span \
class="o">*</span> <span class="n">detail</span> <span class="o">=</span> <span \
class="mi">0</span><span class="p">)</span> <span class="k">const</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just \
curious -- why is the detail parameter still const char*</pre> </div>
<br />
<p>- Boudewijn</p>
<br />
<p>On October 20th, 2010, 10:01 a.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated 2010-10-20 10:01:01</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use const QString & instead of const char * as parameters. This \
reduces the number of conversions as the string is now converted only once and not \
every time a function is called from within.
Also use attributeNS directly without checking if the attribute is there.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No functionality has changed and it works as it did before the change \
only faster</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/odf/KoStyleStack.h <span style="color: \
grey">(1186972)</span></li>
<li>trunk/koffice/libs/odf/KoStyleStack.cpp <span style="color: \
grey">(1186972)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5669/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic