--===============1719410191== Content-Type: multipart/alternative; boundary="===============5049320399517209138==" --===============5049320399517209138== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5655/#review8244 ----------------------------------------------------------- Ok from me, I have not applied it, though. - Thomas On 2010-10-19 17:15:04, Adam Pigg wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5655/ > ----------------------------------------------------------- > = > (Updated 2010-10-19 17:15:04) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Port KoDocumentInfoDlg to akonadi becuase KABC::StdAddressBook is depreca= ted (and not shipped on maemo). Akonadi devs suggested this approach. > = > I probably also should change the cursor to a 'busy' while the search is = occuring, though it should be fast. > = > Still to come will be replacing other places where StdAddressBook is used. > = > This is almost certainly for after the next release, and may need some #i= f magic to work with older kdelibs, unless the minimum version is increased= to ~4.5 i guess. > = > = > Diffs > ----- > = > trunk/koffice/libs/main/CMakeLists.txt 1186295 = > trunk/koffice/libs/main/KoDocumentInfoDlg.h 1186295 = > trunk/koffice/libs/main/KoDocumentInfoDlg.cpp 1186295 = > = > Diff: http://svn.reviewboard.kde.org/r/5655/diff > = > = > Testing > ------- > = > Not a lot! Actually, it doesnt work here at the moment. The info from t= he first function works fine, but no results are returned by the job. Spea= king in #kontact, this seems to be a regression with current trunk, and the= code _should_ work ;) > = > = > Thanks, > = > Adam > = > --===============5049320399517209138== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5655/ 

Ok from me=
, I have not applied it, though.

- Thomas


On October 19th, 2010, 5:15 p.m., Adam Pigg wrote:

Review request for KOffice.
By Adam Pigg.

Updated 2010-10-19 17:15:04

Descripti= on 

Port KoDocumentInfoDlg to akonadi becuase KABC::StdAddressBo=
ok is deprecated (and not shipped on maemo).  Akonadi devs suggested this a=
pproach.

I probably also should change the cursor to a 'busy' while the sear=
ch is occuring, though it should be fast.

Still to come will be replacing other places where StdAddressBook is used.

This is almost certainly for after the next release, and may need some #if =
magic to work with older kdelibs, unless the minimum version is increased t=
o ~4.5 i guess.

Testing <= /h1> 
Not a lot!  Actually, it doesnt work here at the moment.  Th=
e info from the first function works fine, but no results are returned by t=
he job.  Speaking in #kontact, this seems to be a regression with current t=
runk, and the code _should_ work ;)

Diffs=

  • trunk/koffice/libs/main/CMakeLists.txt (11= 86295)
  • trunk/koffice/libs/main/KoDocumentInfoDlg.h (1186295)

View Diff
--===============5049320399517209138==-- --===============1719410191== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1719410191==--