This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5655/

Ok from me, I have not applied it, though.

- Thomas


On October 19th, 2010, 5:15 p.m., Adam Pigg wrote:

Review request for KOffice.
By Adam Pigg.

Updated 2010-10-19 17:15:04

Description

Port KoDocumentInfoDlg to akonadi becuase KABC::StdAddressBook is deprecated (and not shipped on maemo).  Akonadi devs suggested this approach.

I probably also should change the cursor to a 'busy' while the search is occuring, though it should be fast.

Still to come will be replacing other places where StdAddressBook is used.

This is almost certainly for after the next release, and may need some #if magic to work with older kdelibs, unless the minimum version is increased to ~4.5 i guess.

Testing

Not a lot!  Actually, it doesnt work here at the moment.  The info from the first function works fine, but no results are returned by the job.  Speaking in #kontact, this seems to be a regression with current trunk, and the code _should_ work ;)

Diffs

  • trunk/koffice/libs/main/CMakeLists.txt (1186295)
  • trunk/koffice/libs/main/KoDocumentInfoDlg.h (1186295)
  • trunk/koffice/libs/main/KoDocumentInfoDlg.cpp (1186295)

View Diff