[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Port KoDocumentInfoDlg to akonadi
From: "Adam Pigg" <adam () piggz ! co ! uk>
Date: 2010-10-18 21:52:48
Message-ID: 20101018215248.10904.13636 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5655/#review8213
-----------------------------------------------------------
trunk/koffice/libs/main/KoDocumentInfoDlg.cpp
<http://svn.reviewboard.kde.org/r/5655/#comment8481>
That is there for debugging purposes :) .... maybe could use a messageb=
ox if no contact is found, or just leave it with the basic info.
- Adam
On 2010-10-18 21:39:47, Adam Pigg wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5655/
> -----------------------------------------------------------
> =
> (Updated 2010-10-18 21:39:47)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> Port KoDocumentInfoDlg to akonadi becuase KABC::StdAddressBook is depreca=
ted (and not shipped on maemo). Akonadi devs suggested this approach.
> =
> I probably also should change the cursor to a 'busy' while the search is =
occuring, though it should be fast.
> =
> Still to come will be replacing other places where StdAddressBook is used.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/libs/main/CMakeLists.txt 1186295 =
> trunk/koffice/libs/main/KoDocumentInfoDlg.h 1186295 =
> trunk/koffice/libs/main/KoDocumentInfoDlg.cpp 1186295 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5655/diff
> =
> =
> Testing
> -------
> =
> Not a lot! Actually, it doesnt work here at the moment. The info from t=
he first function works fine, but no results are returned by the job. Spea=
king in #kontact, this seems to be a regression with current trunk, and the=
code _should_ work ;)
> =
> =
> Thanks,
> =
> Adam
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5655/">http://svn.reviewboard.kde.org/r/5655/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5655/diff/1/?file=39735#file39735line448" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/main/KoDocumentInfoDlg.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KoDocumentInfoDlg::slotDeleteAuthorInfo()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">445</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">d</span><span class="o">-></span><span class="n">m_authorUi</span><span \
class="o">-></span><span class="n">leTitle</span><span class="o">-></span><span \
class="n">setText</span><span class="p">(</span><span class="s">"not \
found"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That is \
there for debugging purposes :) .... maybe could use a messagebox if no contact is \
found, or just leave it with the basic info.</pre> </div>
<br />
<p>- Adam</p>
<br />
<p>On October 18th, 2010, 9:39 p.m., Adam Pigg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Adam Pigg.</div>
<p style="color: grey;"><i>Updated 2010-10-18 21:39:47</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port KoDocumentInfoDlg to akonadi becuase KABC::StdAddressBook is \
deprecated (and not shipped on maemo). Akonadi devs suggested this approach.
I probably also should change the cursor to a 'busy' while the search is \
occuring, though it should be fast.
Still to come will be replacing other places where StdAddressBook is used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Not a lot! Actually, it doesnt work here at the moment. The info from \
the first function works fine, but no results are returned by the job. Speaking in \
#kontact, this seems to be a regression with current trunk, and the code _should_ \
work ;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/main/CMakeLists.txt <span style="color: \
grey">(1186295)</span></li>
<li>trunk/koffice/libs/main/KoDocumentInfoDlg.h <span style="color: \
grey">(1186295)</span></li>
<li>trunk/koffice/libs/main/KoDocumentInfoDlg.cpp <span style="color: \
grey">(1186295)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5655/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic