[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: KoAbstraction Library
From: "Jaroslaw Staniek" <staniek () kde ! org>
Date: 2010-10-18 19:46:22
Message-ID: 20101018194622.5876.45201 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-18 14:59:31, Boudewijn Rempt wrote:
> > I'm not totally convinced that this puts the abstraction in the right place -- \
> > after chatting with Thorsten, we came to the conclusion that we might want to \
> > offer some kind of non-gui programmatic interface to the tool plugins. But that's \
> > not something that's already worked out, and since this only touches \
> > koffice/tools, not the core, I'm fine with this approach. I think it should still \
> > be designated experimental, though.
> > And while I'm fine with committing, I think Mani or Gopalalakrishna should have \
> > the last word.
Thanks. Guys, if you want, please add hints, notes and requests. I'd like to mention \
that quite a lot of functionality that stays in f-office for now, including code for \
formatting, is planned for the abstraction. See also \
http://wiki.koffice.org/index.php?title=Libs/KoAbstraction#TODOs
- Jaroslaw
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5635/#review8208
-----------------------------------------------------------
On 2010-10-17 21:06:10, Jaroslaw Staniek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5635/
> -----------------------------------------------------------
>
> (Updated 2010-10-17 21:06:10)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> KoAbstraction Library
>
> This is library utilizing facade design pattern in order to simplify implementation \
> of custom graphical interfaces for various applications. This way standalone \
> KOffice viewer widget can be delivered too.
> * added koabstraction in tools/koabstraction/
> * it's dependent on KSpread so for my understanding does not fit to libs/
> * moved code that belong to koabstraction from f-office/, that is:
> ** KoAbstractApplication intermediate class
> ** KoAbstractApplicationController
> ** FoCellTool (renamed to KoCellTool)
> ** FoCellToolFactory (renamed to KoCellToolFactory, made private class)
> ** RemoveSheet (renamed to RemoveSheetCommand for more clarity, made private class)
> * FoCellEditor temporarily moved to koabstraction/ as private class, will be back \
> here as soon as interface abstracting cell editor is ready
> * finished simplifying f-office/CMakeLists.txt (it looked like standalone project \
> before with using find_package(Qt4 4.5.0 REQUIRED), etc.)
> * KoAbstractApplicationImpl.cpp stays in tools/f-office/ as it's a wrapper for \
> building KoAbstractApplication.moc properly
> * added KoExternalEditorInterface class which is implemented by FoExternalEditor in \
> f-office, abstraction uses it instead of concrete implementation of \
> editor
> * FoImageSelectionWidget is not instatiated at all so constructor was removed
> * PanTool_ID, TextTool_ID, CellTool_ID constants from f-office replaced by \
> KoAbstractApplicationController::panToolFactoryId(), etc. in koabstraction, so the \
> tools can be freely accessed in any implementation
> * KoAbstractApplicationController uses controller() which is now KoController only; \
> in contexts when KoControllerWidget is needed, appropriate dynamic_case is defined \
> as KoAbstractApplicationController::controllerWidget(); this leads to API that \
> could be usable for graphics-view-based UIs
> * PresentationTool is back in f-office's MainWindow now, same for \
> StoreButtonPreview; code related to them is moved from abstraction to f-office
>
> More discussion at http://wiki.koffice.org/index.php?title=Libs/KoAbstraction
>
>
> Diffs
> -----
>
> branches/work/koffice-essen/CMakeLists.txt 1186326
> branches/work/koffice-essen/tools/CMakeLists.txt 1186326
> branches/work/koffice-essen/tools/f-office/CMakeLists.txt 1186326
> branches/work/koffice-essen/tools/f-office/Common.h 1186326
> branches/work/koffice-essen/tools/f-office/FoCellEditor.h 1186326
> branches/work/koffice-essen/tools/f-office/FoCellEditor.cpp 1186326
> branches/work/koffice-essen/tools/f-office/FoCellTool.h 1186326
> branches/work/koffice-essen/tools/f-office/FoCellTool.cpp 1186326
> branches/work/koffice-essen/tools/f-office/FoCellToolFactory.h 1186326
> branches/work/koffice-essen/tools/f-office/FoCellToolFactory.cpp 1186326
> branches/work/koffice-essen/tools/f-office/FoExternalEditor.h 1186326
> branches/work/koffice-essen/tools/f-office/FoExternalEditor.cpp 1186326
> branches/work/koffice-essen/tools/f-office/FoImageSelectionWidget.h 1186326
> branches/work/koffice-essen/tools/f-office/FoImageSelectionWidget.cpp 1186326
> branches/work/koffice-essen/tools/f-office/KoAbstractApplicationController.h \
> 1186326 branches/work/koffice-essen/tools/f-office/KoAbstractApplicationController.cpp \
> 1186326 branches/work/koffice-essen/tools/f-office/KoAbstractApplicationImpl.h \
> 1186326 branches/work/koffice-essen/tools/f-office/KoAbstractApplicationImpl.cpp \
> 1186326 branches/work/koffice-essen/tools/f-office/MainWindow.h 1186326
> branches/work/koffice-essen/tools/f-office/MainWindow.cpp 1186326
> branches/work/koffice-essen/tools/f-office/RemoveSheet.h 1186326
> branches/work/koffice-essen/tools/f-office/RemoveSheet.cpp 1186326
> branches/work/koffice-essen/tools/koabstraction/CMakeLists.txt PRE-CREATION
> branches/work/koffice-essen/tools/koabstraction/FoCellEditor.h PRE-CREATION
> branches/work/koffice-essen/tools/koabstraction/FoCellEditor.cpp PRE-CREATION
> branches/work/koffice-essen/tools/koabstraction/KoAbstractApplication.h \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/KoAbstractApplicationController.h \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/KoAbstractApplicationController.cpp \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/KoAbstractApplicationImpl.h \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/KoCellTool.h \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/KoCellTool.cpp \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/KoCellToolFactory.h \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/KoCellToolFactory.cpp \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/KoExternalEditorInterface.h \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/RemoveSheetCommand.h \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/RemoveSheetCommand.cpp \
> PRE-CREATION branches/work/koffice-essen/tools/koabstraction/koabstraction_export.h \
> PRE-CREATION
> Diff: http://svn.reviewboard.kde.org/r/5635/diff
>
>
> Testing
> -------
>
> FreOffice builds and runs as in previous two stages. Did some testing on standalone \
> minimal test application which implements the interfaces - documents are opened and \
> displayed properly.
>
> Thanks,
>
> Jaroslaw
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5635/">http://svn.reviewboard.kde.org/r/5635/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 18th, 2010, 2:59 p.m., <b>Boudewijn \
Rempt</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not totally convinced that this puts the abstraction in the \
right place -- after chatting with Thorsten, we came to the conclusion that we might \
want to offer some kind of non-gui programmatic interface to the tool plugins. But \
that's not something that's already worked out, and since this only touches \
koffice/tools, not the core, I'm fine with this approach. I think it should still \
be designated experimental, though.
And while I'm fine with committing, I think Mani or Gopalalakrishna should have \
the last word.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks. Guys, if you \
want, please add hints, notes and requests. I'd like to mention that quite a lot \
of functionality that stays in f-office for now, including code for formatting, is \
planned for the abstraction. See also \
http://wiki.koffice.org/index.php?title=Libs/KoAbstraction#TODOs</pre> <br />
<p>- Jaroslaw</p>
<br />
<p>On October 17th, 2010, 9:06 p.m., Jaroslaw Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Jaroslaw Staniek.</div>
<p style="color: grey;"><i>Updated 2010-10-17 21:06:10</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KoAbstraction Library
This is library utilizing facade design pattern in order to simplify implementation \
of custom graphical interfaces for various applications. This way standalone KOffice \
viewer widget can be delivered too.
* added koabstraction in tools/koabstraction/
* it's dependent on KSpread so for my understanding does not fit to libs/
* moved code that belong to koabstraction from f-office/, that is:
** KoAbstractApplication intermediate class
** KoAbstractApplicationController
** FoCellTool (renamed to KoCellTool)
** FoCellToolFactory (renamed to KoCellToolFactory, made private class)
** RemoveSheet (renamed to RemoveSheetCommand for more clarity, made private class)
* FoCellEditor temporarily moved to koabstraction/ as private class, will be back \
here as soon as interface abstracting cell editor is ready
* finished simplifying f-office/CMakeLists.txt (it looked like standalone project \
before with using find_package(Qt4 4.5.0 REQUIRED), etc.)
* KoAbstractApplicationImpl.cpp stays in tools/f-office/ as it's a wrapper for \
building KoAbstractApplication.moc properly
* added KoExternalEditorInterface class which is implemented by FoExternalEditor in \
f-office, abstraction uses it instead of concrete implementation of \
editor
* FoImageSelectionWidget is not instatiated at all so constructor was removed
* PanTool_ID, TextTool_ID, CellTool_ID constants from f-office replaced by \
KoAbstractApplicationController::panToolFactoryId(), etc. in koabstraction, so the \
tools can be freely accessed in any implementation
* KoAbstractApplicationController uses controller() which is now KoController only; \
in contexts when KoControllerWidget is needed, appropriate dynamic_case is defined as \
KoAbstractApplicationController::controllerWidget(); this leads to API that could be \
usable for graphics-view-based UIs
* PresentationTool is back in f-office's MainWindow now, same for \
StoreButtonPreview; code related to them is moved from abstraction to f-office
More discussion at http://wiki.koffice.org/index.php?title=Libs/KoAbstraction</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">FreOffice builds and runs as in previous two stages. Did some testing on \
standalone minimal test application which implements the interfaces - documents are \
opened and displayed properly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/work/koffice-essen/CMakeLists.txt <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/CMakeLists.txt <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/CMakeLists.txt <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/Common.h <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/FoCellEditor.h <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/FoCellEditor.cpp <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/FoCellTool.h <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/FoCellTool.cpp <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/FoCellToolFactory.h <span \
style="color: grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/FoCellToolFactory.cpp <span \
style="color: grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/FoExternalEditor.h <span \
style="color: grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/FoExternalEditor.cpp <span \
style="color: grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/FoImageSelectionWidget.h <span \
style="color: grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/FoImageSelectionWidget.cpp <span \
style="color: grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/KoAbstractApplicationController.h \
<span style="color: grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/KoAbstractApplicationController.cpp \
<span style="color: grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/KoAbstractApplicationImpl.h <span \
style="color: grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/KoAbstractApplicationImpl.cpp <span \
style="color: grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/MainWindow.h <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/MainWindow.cpp <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/RemoveSheet.h <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/f-office/RemoveSheet.cpp <span style="color: \
grey">(1186326)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/FoCellEditor.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/FoCellEditor.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/KoAbstractApplication.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/KoAbstractApplicationController.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/KoAbstractApplicationController.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/KoAbstractApplicationImpl.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/KoCellTool.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/KoCellTool.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/KoCellToolFactory.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/KoCellToolFactory.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/KoExternalEditorInterface.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/RemoveSheetCommand.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/RemoveSheetCommand.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>branches/work/koffice-essen/tools/koabstraction/koabstraction_export.h <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5635/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic