[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: patch for adding KoShapeLoadingContext to
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2010-10-18 13:52:31
Message-ID: 201010181552.32181.inge () lysator ! liu ! se
[Download RAW message or body]

On Monday, October 18, 2010 09:20:36 Thorsten Zachmann wrote:
> Hello all,
> 
> I send that to the list as reviewboard is not allowing me to create new
> review requests at the moment.
> 
> The attached patch adds the KoShapeLoadingContext the the
> KoShapeFactoryBase::supports method so that information stored in there can
> be used to determine if the factory supports the shape.
> 
> Reason:
> 
> At the moment when a <draw:image> tag is encountered it is always tried
> first if the VectorShape does support the data in it, before the
> PictureShape is tried. That creates for every image that is not a emf/wmf
> first a VectorShape which then tries to load the data which fails for
> png/jpeg .... . The object is then destructed and the next shape in line
> the PictureShape will get a go. With passing the KoShapeLoadingContext to
> the support method it is possible to check the mime type of the image and
> only create a VectorShape when it is needed. With that all the unneeded
> steps can be avoided which results in better loading performance.
> 
> The patch only adds the KoShapeLoadingContext to the supports method. It
> removes some wrong test form the KarbonCalligraphicShapeFactory and
> optimizes the KoPathShapeFactory to check for the namespace only ones.

Ship it!

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]