'Re: Review Request: if releasing the mouse, there is no pressure'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: if releasing the mouse, there is no pressure
From:       "Adam C." <nospam () xibo ! at>
Date:       2010-10-17 10:56:22
Message-ID: 20101017105622.7860.42872 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On 2010-10-03 07:22:24, Cyrille Berger wrote:
> >

i discovered, that my solution won't work. as far, as i can see, the only w=
ay to fix the weirdness with the tablet buttons during a stroke is to patch=
 qt/x11.

the weirdness is a minor one anyway, so i suppose, that our users can live =
with it..

- Adam

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5520/#review7947
-----------------------------------------------------------

On 2010-10-02 20:08:12, Adam C. wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5520/
> -----------------------------------------------------------
> =

> (Updated 2010-10-02 20:08:12)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> This patch changes KoPointerEvent, so that it behaves similar to QTabletE=
vent. If there is a tablet release event, it has pressure 0, we should do t=
he same.
> =

> (This is part of a patch to fix the weird behaviour of pressing a tablet =
button, while drawing)
> =

> =

> Diffs
> -----
> =

>   /trunk/koffice/libs/flake/KoPointerEvent.cpp 1181649 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5520/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Adam
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5520/">http://svn.reviewboard.kde.org/r/5520/</a>
  </td>
    </tr>
   </table>
   <br />

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i discovered, that my \
solution won&#39;t work. as far, as i can see, the only way to fix the weirdness with \
the tablet buttons during a stroke is to patch qt/x11.

the weirdness is a minor one anyway, so i suppose, that our users can live with \
it..</pre> <br />

<p>- Adam</p>

<br />
<p>On October 2nd, 2010, 8:08 p.m., Adam C. wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Adam C..</div>

<p style="color: grey;"><i>Updated 2010-10-02 20:08:12</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch changes KoPointerEvent, so that it behaves similar to \
QTabletEvent. If there is a tablet release event, it has pressure 0, we should do the \
same.

(This is part of a patch to fix the weird behaviour of pressing a tablet button, \
while drawing)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/libs/flake/KoPointerEvent.cpp <span style="color: \
grey">(1181649)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5520/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 