[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Text run arround (wrap) for more shapes. New
From: "Pavol Korinek" <pavol.korinek () ixonos ! com>
Date: 2010-10-14 13:35:35
Message-ID: 20101014133535.17724.90980 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-06 18:43:49, Thomas Zander wrote:
> > /trunk/koffice/plugins/textshape/Layout.h, line 181
> > <http://svn.reviewboard.kde.org/r/5195/diff/3/?file=35304#file35304line181>
> >
> > If you add a new variable in C++ you should add it to the constructor to be \
> > initialized.
Hello Thomas, are you finishing work on release ? Do you have little more time ? Can \
we continue with review of advanced 'text wrap' around shapes ? All changes were made \
as you suggested last time.
- Pavol
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5195/#review7434
-----------------------------------------------------------
On 2010-09-07 17:42:55, Pavol Korinek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5195/
> -----------------------------------------------------------
>
> (Updated 2010-09-07 17:42:55)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This is text run around shapes implementation. Contains new layout methods for \
> fitting text between line intersect shapes. Better bound for shapes. New fit() \
> method implemented. Possible to use old tryFit() method instead new fit() to see \
> differences. (tryFit method is called on two times in KWTextDocumentLayout) Unit \
> tests for various scenarios implemented too.
>
> Diffs
> -----
>
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.h 1172585
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1172585
> /trunk/koffice/kword/part/frames/Outline.h 1172585
> /trunk/koffice/kword/part/frames/Outline.cpp 1172585
> /trunk/koffice/kword/part/tests/TestDocumentLayout.h 1172585
> /trunk/koffice/kword/part/tests/TestDocumentLayout.cpp 1172585
> /trunk/koffice/libs/kotext/KoTextDocumentLayout.h 1172585
> /trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp 1172585
> /trunk/koffice/plugins/textshape/Layout.h 1172585
> /trunk/koffice/plugins/textshape/Layout.cpp 1172585
>
> Diff: http://svn.reviewboard.kde.org/r/5195/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pavol
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5195/">http://svn.reviewboard.kde.org/r/5195/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 6th, 2010, 6:43 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5195/diff/3/?file=35304#file35304line181" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/koffice/plugins/textshape/Layout.h</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">181</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qreal</span> <span class="n">m_maxLineHeight</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you add a new \
variable in C++ you should add it to the constructor to be initialized.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello \
Thomas, are you finishing work on release ? Do you have little more time ? Can we \
continue with review of advanced 'text wrap' around shapes ? All changes were \
made as you suggested last time.</pre> <br />
<p>- Pavol</p>
<br />
<p>On September 7th, 2010, 5:42 p.m., Pavol Korinek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>
<p style="color: grey;"><i>Updated 2010-09-07 17:42:55</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is text run around shapes implementation. Contains new layout \
methods for fitting text between line intersect shapes. Better bound for shapes. New \
fit() method implemented. Possible to use old tryFit() method instead new fit() to \
see differences. (tryFit method is called on two times in KWTextDocumentLayout) Unit \
tests for various scenarios implemented too.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.h <span style="color: \
grey">(1172585)</span></li>
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp <span style="color: \
grey">(1172585)</span></li>
<li>/trunk/koffice/kword/part/frames/Outline.h <span style="color: \
grey">(1172585)</span></li>
<li>/trunk/koffice/kword/part/frames/Outline.cpp <span style="color: \
grey">(1172585)</span></li>
<li>/trunk/koffice/kword/part/tests/TestDocumentLayout.h <span style="color: \
grey">(1172585)</span></li>
<li>/trunk/koffice/kword/part/tests/TestDocumentLayout.cpp <span style="color: \
grey">(1172585)</span></li>
<li>/trunk/koffice/libs/kotext/KoTextDocumentLayout.h <span style="color: \
grey">(1172585)</span></li>
<li>/trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp <span style="color: \
grey">(1172585)</span></li>
<li>/trunk/koffice/plugins/textshape/Layout.h <span style="color: \
grey">(1172585)</span></li>
<li>/trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1172585)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5195/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic