[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: fix single key shortcut bug in flake
From: "Adam C." <nospam () xibo ! at>
Date: 2010-10-07 10:25:12
Message-ID: 20101007102512.12408.14382 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-07 03:51:07, Thorsten Zachmann wrote:
> >
why is it unlikely to change?
maybe one day we will have a tool, that can have a text and a normal mode.that's the \
reason i called it isInTextMode() and not isTextTool().
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5507/#review8005
-----------------------------------------------------------
On 2010-10-06 20:17:53, Adam C. wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5507/
> -----------------------------------------------------------
>
> (Updated 2010-10-06 20:17:53)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> this fixes the bug in flake, where single key shortcuts prevented text input.
>
> to reproduce, do the following:
> 1. open shortcuts configuration and assign the shortcut "a" to the about dialogue.
> 2. activate default tool => a shows about dialogue
> 3. create textshape and write something with a => about dialogue shows, but it \
> shouldn't
> In the qt lib textinputs are working, while there are these shortcuts, so in flake \
> it should also work.
> the patch works this way:
> the canvas forwards bool QWidget::event(QEvent* theEvent) to KoToolProxy. The tool \
> proxy asks the current tool, if it is in text mode (isInTextMode) and interrupts \
> the shortcut if so.
> I've tried to change all canvases and all text tools, but i'm not sure, if i found \
> everything.
>
> Diffs
> -----
>
> /trunk/koffice/kformula/flake/KoFormulaTool.h 1182829
> /trunk/koffice/kformula/flake/KoFormulaTool.cpp 1182829
> /trunk/koffice/kspread/ui/CellToolBase.h 1182829
> /trunk/koffice/kspread/ui/CellToolBase.cpp 1182829
> /trunk/koffice/libs/flake/KoToolBase.h 1182829
> /trunk/koffice/libs/flake/KoToolBase.cpp 1182829
> /trunk/koffice/libs/flake/KoToolBase_p.h 1182829
> /trunk/koffice/plugins/artistictextshape/ArtisticTextTool.h 1182829
> /trunk/koffice/plugins/artistictextshape/ArtisticTextTool.cpp 1182829
> /trunk/koffice/plugins/textshape/TextTool.h 1182829
> /trunk/koffice/plugins/textshape/TextTool.cpp 1182829
>
> Diff: http://svn.reviewboard.kde.org/r/5507/diff
>
>
> Testing
> -------
>
> i've tested kword, kspread, kpresenter, kivio, karbon and krita. in kexi it's \
> impossible to set single key shortcuts and in kformula i wasn't able to open a text \
> canvas.
>
> Thanks,
>
> Adam
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5507/">http://svn.reviewboard.kde.org/r/5507/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why is it unlikely to \
change?
maybe one day we will have a tool, that can have a text and a normal mode.that's \
the reason i called it isInTextMode() and not isTextTool().</pre> <br />
<p>- Adam</p>
<br />
<p>On October 6th, 2010, 8:17 p.m., Adam C. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Adam C..</div>
<p style="color: grey;"><i>Updated 2010-10-06 20:17:53</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this fixes the bug in flake, where single key shortcuts prevented text \
input.
to reproduce, do the following:
1. open shortcuts configuration and assign the shortcut "a" to the about \
dialogue. 2. activate default tool => a shows about dialogue
3. create textshape and write something with a => about dialogue shows, but it \
shouldn't
In the qt lib textinputs are working, while there are these shortcuts, so in flake it \
should also work.
the patch works this way:
the canvas forwards bool QWidget::event(QEvent* theEvent) to KoToolProxy. The tool \
proxy asks the current tool, if it is in text mode (isInTextMode) and interrupts the \
shortcut if so.
I've tried to change all canvases and all text tools, but i'm not sure, if i \
found everything. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i've tested kword, kspread, kpresenter, kivio, karbon and krita. in \
kexi it's impossible to set single key shortcuts and in kformula i wasn't \
able to open a text canvas.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kformula/flake/KoFormulaTool.h <span style="color: \
grey">(1182829)</span></li>
<li>/trunk/koffice/kformula/flake/KoFormulaTool.cpp <span style="color: \
grey">(1182829)</span></li>
<li>/trunk/koffice/kspread/ui/CellToolBase.h <span style="color: \
grey">(1182829)</span></li>
<li>/trunk/koffice/kspread/ui/CellToolBase.cpp <span style="color: \
grey">(1182829)</span></li>
<li>/trunk/koffice/libs/flake/KoToolBase.h <span style="color: \
grey">(1182829)</span></li>
<li>/trunk/koffice/libs/flake/KoToolBase.cpp <span style="color: \
grey">(1182829)</span></li>
<li>/trunk/koffice/libs/flake/KoToolBase_p.h <span style="color: \
grey">(1182829)</span></li>
<li>/trunk/koffice/plugins/artistictextshape/ArtisticTextTool.h <span style="color: \
grey">(1182829)</span></li>
<li>/trunk/koffice/plugins/artistictextshape/ArtisticTextTool.cpp <span \
style="color: grey">(1182829)</span></li>
<li>/trunk/koffice/plugins/textshape/TextTool.h <span style="color: \
grey">(1182829)</span></li>
<li>/trunk/koffice/plugins/textshape/TextTool.cpp <span style="color: \
grey">(1182829)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5507/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic