'Re: Review Request: fix bug: not working mouse middle and right click'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: fix bug: not working mouse middle and right click
From:       "Cyrille Berger" <cberger () cberger ! net>
Date:       2010-10-03 9:34:17
Message-ID: 20101003093417.19023.96325 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5478/#review7948
-----------------------------------------------------------

Ship it!

I investigated Qt, unfortunately, it is not as easy I hoped, since when the=
 tablet event is dropped it is resent through X11, so it would require to f=
ind how to get button states from X11.

Since there is no side effect, I guess we have to live with an other workar=
ound and hope that it works for a longer time than previous attempt.

- Cyrille

On 2010-09-29 15:35:42, Adam wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5478/
> -----------------------------------------------------------
> =

> (Updated 2010-09-29 15:35:42)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> QTabletEvent has no information about which button was pressed on the sty=
lus. We have to reject it, so that it gets resent as a QMouseEvent with the=
 correct buttons.
> =

> =

> Diffs
> -----
> =

>   /trunk/koffice/libs/flake/KoToolProxy.cpp 1180634 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5478/diff
> =

> =

> Testing
> -------
> =

> panning and popup palette in krita works now.
> =

> =

> Thanks,
> =

> Adam
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5478/">http://svn.reviewboard.kde.org/r/5478/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I investigated Qt, \
unfortunately, it is not as easy I hoped, since when the tablet event is dropped it \
is resent through X11, so it would require to find how to get button states from X11.

Since there is no side effect, I guess we have to live with an other workaround and \
hope that it works for a longer time than previous attempt.</pre>  <br />

<p>- Cyrille</p>

<br />
<p>On September 29th, 2010, 3:35 p.m., Adam wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Adam.</div>

<p style="color: grey;"><i>Updated 2010-09-29 15:35:42</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QTabletEvent has no information about which button was pressed on the \
stylus. We have to reject it, so that it gets resent as a QMouseEvent with the \
correct buttons.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">panning and popup palette in krita works now.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/libs/flake/KoToolProxy.cpp <span style="color: \
grey">(1180634)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5478/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 