[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: fix bug: not working mouse middle and right click
From: "Adam" <nospam () xibo ! at>
Date: 2010-09-29 16:51:44
Message-ID: 20100929165144.19510.89487 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-29 16:18:47, Thomas Zander wrote:
> > I'm not entire sure I follow the logic; tablet events have many more op=
tions than just left/right (/middle) button, they have two enums for this o=
n the tablet event.
> > =
> > But, not following the logic I'm going to take a look at the diff and n=
otice a logic issue; the the events should first be offered to the tool and=
the tool can decide if it wants to accept it. Your code at the top decides=
to ignore the event and as such it will never be sent to the tool.
> > Deciding to never send it to the tool will probably make various tools =
be disappointed.
> > =
> > Also it should be noted that there is no one to one relation for tablet=
and mouse events. A unloaded system gets between 2 and 10 times as many t=
ablet events as mouse events. Ignoring the tablet event will make data get =
lost.
Yes, they have more options, but i didn't find a right/middle button option=
. the documentation says, that there is one enum for device and one for poi=
nter type. there is no enum for the button, at least i didn't find one. if =
there is, then please tell me the method name and i will admit, that i'm ve=
ry stupid.
if you are so kind as to go to the diff, then please also be so kind and lo=
ok at the comments or at qt documentation. the documentation states, that i=
t will be resent as a qmouseevent, here is the link: http://doc.trolltech.c=
om/4.6/qtabletevent.html#details By the way, if you think, that the tools d=
on't get the event with my change, then explain, how it would be possible, =
that panning has started to work.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5478/#review7881
-----------------------------------------------------------
On 2010-09-29 15:35:42, Adam wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5478/
> -----------------------------------------------------------
> =
> (Updated 2010-09-29 15:35:42)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> QTabletEvent has no information about which button was pressed on the sty=
lus. We have to reject it, so that it gets resent as a QMouseEvent with the=
correct buttons.
> =
> =
> Diffs
> -----
> =
> /trunk/koffice/libs/flake/KoToolProxy.cpp 1180634 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5478/diff
> =
> =
> Testing
> -------
> =
> panning and popup palette in krita works now.
> =
> =
> Thanks,
> =
> Adam
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5478/">http://svn.reviewboard.kde.org/r/5478/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 29th, 2010, 4:18 p.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm not entire sure I follow the logic; tablet events have many more \
options than just left/right (/middle) button, they have two enums for this on the \
tablet event.
But, not following the logic I'm going to take a look at the diff and notice a \
logic issue; the the events should first be offered to the tool and the tool can \
decide if it wants to accept it. Your code at the top decides to ignore the event and \
as such it will never be sent to the tool. Deciding to never send it to the tool will \
probably make various tools be disappointed.
Also it should be noted that there is no one to one relation for tablet and mouse \
events. A unloaded system gets between 2 and 10 times as many tablet events as mouse \
events. Ignoring the tablet event will make data get lost.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, they have more \
options, but i didn't find a right/middle button option. the documentation says, \
that there is one enum for device and one for pointer type. there is no enum for the \
button, at least i didn't find one. if there is, then please tell me the method \
name and i will admit, that i'm very stupid.
if you are so kind as to go to the diff, then please also be so kind and look at the \
comments or at qt documentation. the documentation states, that it will be resent as \
a qmouseevent, here is the link: \
http://doc.trolltech.com/4.6/qtabletevent.html#details By the way, if you think, that \
the tools don't get the event with my change, then explain, how it would be \
possible, that panning has started to work.
</pre>
<br />
<p>- Adam</p>
<br />
<p>On September 29th, 2010, 3:35 p.m., Adam wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Adam.</div>
<p style="color: grey;"><i>Updated 2010-09-29 15:35:42</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QTabletEvent has no information about which button was pressed on the \
stylus. We have to reject it, so that it gets resent as a QMouseEvent with the \
correct buttons.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">panning and popup palette in krita works now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/libs/flake/KoToolProxy.cpp <span style="color: \
grey">(1180634)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5478/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic