--===============1937693550== Content-Type: multipart/alternative; boundary="===============2200280312102985832==" --===============2200280312102985832== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5464/#review7870 ----------------------------------------------------------- Ship it! Thank you for the great explanation; please commit to trunk. - Thomas On 2010-09-28 11:21:50, Pavol Korinek wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5464/ > ----------------------------------------------------------- > = > (Updated 2010-09-28 11:21:50) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > I've made investigation regarding condition at line 555 in KWTextDocument= Layout.cpp: > bottomOfText > m_state->shape->size().height() && document()->blockCount(= ) =3D=3D 1 > I've found a real problem, which can by very simply shown. Open KWork -> = change font size to 72 -> hold on wrining 'A' till you come to second page.= Than Kword starts to loop. Why ? Because mentioned condition is true. We h= ave one block and we'd like to go on second page. There's return after that= condition and kword than do the same in loop to infinity. You now that it'= s basic functionality, which should works well. > I suggest one of two options: > 1. remove condition. Collect problematic files by testers and do investig= ation. Than make solution. > 2. add one more check to condition: if frame is header or footer. This bl= ock was added to resize header or footer size. That can be show via svn bla= me and comment in commit. > Second option is my patch. > = > = > Diffs > ----- > = > /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1180481 = > = > Diff: http://svn.reviewboard.kde.org/r/5464/diff > = > = > Testing > ------- > = > = > Thanks, > = > Pavol > = > --===============2200280312102985832== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5464/

Ship it!

Thank you =
for the great explanation; please commit to trunk.

- Thomas

On September 28th, 2010, 11:21 a.m., Pavol Korinek wrote:

Review request for KOffice.

By Pavol Korinek.

Updated 2010-09-28 11:21:50

Descripti= on

I've made investigation regarding condition at line 555 =
in KWTextDocumentLayout.cpp:
bottomOfText > m_state->shape->size().height() && document=
()->blockCount() =3D=3D 1
I've found a real problem, which can by very simply shown. Open KWork -=
> change font size to 72 -> hold on wrining 'A' till you come=
 to second page. Than Kword starts to loop. Why ? Because mentioned conditi=
on is true. We have one block and we'd like to go on second page. There=
's return after that condition and kword than do the same in loop to in=
finity. You now that it's basic functionality, which should works well.
I suggest one of two options:
1. remove condition. Collect problematic files by testers and do investigat=
ion. Than make solution.
2. add one more check to condition: if frame is header or footer. This bloc=
k was added to resize header or footer size. That can be show via svn blame=
 and comment in commit.
Second option is my patch.

Diffs=

/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp (1180481)

--===============2200280312102985832==-- --===============1937693550== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1937693550==--