[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice version logics (unintentionally?) changed
From:       zander () kde ! org
Date:       2010-09-29 10:29:48
Message-ID: 201009291229.48692.zander () kde ! org
[Download RAW message or body]

On Wednesday 29. September 2010 12.04.17 Jaroslaw Staniek wrote:
> Hi,
> Regarding this
> http://websvn.kde.org/?view=revision&revision=1158435
> it is no longer possible to check runtime version of koffice (unless
> someone disabled inlines).
> Namely the methods are now equivalent to macros KOFFICE_VERSION_*.
> I propose to revert this before release because current state assumes
> that any code that uses libkomain is distributed and installed
> together with libkomain.

Your usecase makes sense; I'd be in favour of such a move.
The code was not exported and making them inline was the easiest way to start 
using these methods outside of komain.
If I knew about the usecase you state then instead I would have exported the 
methods; would be nice if you can do that.
So, if you want to use those methods using the usecase you described above you 
will need to properly export each of the methods, and indeed re-instate the 
cpp file.

THanks!
-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]