[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Pages get added continuously. Kword LOOP !
From: "Pavol Korinek" <pavol.korinek () ixonos ! com>
Date: 2010-09-28 15:30:52
Message-ID: 20100928153052.24975.36110 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-09-28 15:05:45, Johannes Simon wrote:
> > This exact patch has actually been submitted before ;-)
> >
> > See http://reviewboard.kde.org/r/4174/
> >
> > Apparently a 'proper' solution was not found at this time, but to me it looks \
> > like fixing this is really important. Last time it was discarded, we shouldn't do \
> > this again now, but find a solution instead.. I myself don't know the internals \
> > however, so all I can do is point at the other review request mentioned.
Yes, you right. I know that. Actually Miroslav is not present, so I assigned this \
problem to me. It was partially my idea to solve it that way in his patch. While he \
was pointing to problem with test file, I'm pointing to basic functionality, which I \
thing should be fixed with priority. As I explained in description it can be fixed \
with this patch.
- Pavol
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5464/#review7857
-----------------------------------------------------------
On 2010-09-28 11:21:50, Pavol Korinek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5464/
> -----------------------------------------------------------
>
> (Updated 2010-09-28 11:21:50)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> I've made investigation regarding condition at line 555 in \
> KWTextDocumentLayout.cpp: bottomOfText > m_state->shape->size().height() && \
> document()->blockCount() == 1 I've found a real problem, which can by very simply \
> shown. Open KWork -> change font size to 72 -> hold on wrining 'A' till you come to \
> second page. Than Kword starts to loop. Why ? Because mentioned condition is true. \
> We have one block and we'd like to go on second page. There's return after that \
> condition and kword than do the same in loop to infinity. You now that it's basic \
> functionality, which should works well. I suggest one of two options:
> 1. remove condition. Collect problematic files by testers and do investigation. \
> Than make solution. 2. add one more check to condition: if frame is header or \
> footer. This block was added to resize header or footer size. That can be show via \
> svn blame and comment in commit. Second option is my patch.
>
>
> Diffs
> -----
>
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1180481
>
> Diff: http://svn.reviewboard.kde.org/r/5464/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pavol
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5464/">http://svn.reviewboard.kde.org/r/5464/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 28th, 2010, 3:05 p.m., <b>Johannes \
Simon</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This exact patch has actually been submitted before ;-)
See http://reviewboard.kde.org/r/4174/
Apparently a 'proper' solution was not found at this time, but to me it looks \
like fixing this is really important. Last time it was discarded, we shouldn't do \
this again now, but find a solution instead.. I myself don't know the internals \
however, so all I can do is point at the other review request mentioned.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, you right. I know \
that. Actually Miroslav is not present, so I assigned this problem to me. It was \
partially my idea to solve it that way in his patch. While he was pointing to problem \
with test file, I'm pointing to basic functionality, which I thing should be \
fixed with priority. As I explained in description it can be fixed with this \
patch.</pre> <br />
<p>- Pavol</p>
<br />
<p>On September 28th, 2010, 11:21 a.m., Pavol Korinek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>
<p style="color: grey;"><i>Updated 2010-09-28 11:21:50</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've made investigation regarding condition at line 555 in \
KWTextDocumentLayout.cpp: bottomOfText > m_state->shape->size().height() \
&& document()->blockCount() == 1 I've found a real problem, which can \
by very simply shown. Open KWork -> change font size to 72 -> hold on wrining \
'A' till you come to second page. Than Kword starts to loop. Why ? Because \
mentioned condition is true. We have one block and we'd like to go on second \
page. There's return after that condition and kword than do the same in loop to \
infinity. You now that it's basic functionality, which should works well. I \
suggest one of two options: 1. remove condition. Collect problematic files by testers \
and do investigation. Than make solution. 2. add one more check to condition: if \
frame is header or footer. This block was added to resize header or footer size. That \
can be show via svn blame and comment in commit. Second option is my patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp <span style="color: \
grey">(1180481)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5464/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic