'Review Request: Pages get added continuously. Kword LOOP !'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Pages get added continuously. Kword LOOP !
From:       "Pavol Korinek" <pavol.korinek () ixonos ! com>
Date:       2010-09-28 8:38:30
Message-ID: 20100928083830.16324.20592 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5464/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

I've made investigation regarding condition at line 555 in KWTextDocumentLayout.cpp:
bottomOfText > m_state->shape->size().height() && document()->blockCount() == 1
I've found a real problem, which can by very simply shown. Open KWork -> change font \
size to 72 -> hold on wrining 'A' till you come to second page. Than Kword starts to \
loop. Why ? Because mentioned condition is true. We have one block and we'd like to \
go on second page. There's return after that condition and kword than do the same in \
loop to infinity. You now that it's basic functionality, which should works well. I \
suggest one of two options: 1. remove condition. Collect problematic files by testers \
and do investigation. Than make solution. 2. add one more check to condition: if \
frame is header or footer. This block was added to resize header or footer size. That \
can be show via svn blame and comment in commit. Second option is my patch.

Diffs
-----

  /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1180481 

Diff: http://svn.reviewboard.kde.org/r/5464/diff

Testing
-------

Thanks,

Pavol

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5464/">http://svn.reviewboard.kde.org/r/5464/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;ve made investigation regarding condition at line 555 in \
KWTextDocumentLayout.cpp: bottomOfText &gt; m_state-&gt;shape-&gt;size().height() \
&amp;&amp; document()-&gt;blockCount() == 1 I&#39;ve found a real problem, which can \
by very simply shown. Open KWork -&gt; change font size to 72 -&gt; hold on wrining \
&#39;A&#39; till you come to second page. Than Kword starts to loop. Why ? Because \
mentioned condition is true. We have one block and we&#39;d like to go on second \
page. There&#39;s return after that condition and kword than do the same in loop to \
infinity. You now that it&#39;s basic functionality, which should works well. I \
suggest one of two options: 1. remove condition. Collect problematic files by testers \
and do investigation. Than make solution. 2. add one more check to condition: if \
frame is header or footer. This block was added to resize header or footer size. That \
can be show via svn blame and comment in commit. Second option is my patch.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp <span style="color: \
grey">(1180481)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5464/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 