--===============1421411825== Content-Type: multipart/alternative; boundary="===============7322037598370815488==" --===============7322037598370815488== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-09-11 11:32:46, Johannes Simon wrote: > > I recently committed a patch [1] in trunk that should fix this. I also = checked the test file you mentioned, and it looks good to me. Can you verif= y? > > = > > [1] http://websvn.kde.org/?view=3Drevision&revision=3D1174138 > = > Matus Hanzes wrote: > Thanks for solving it. I have tested it on 1174897. > = > The legend looks better now and the previous problem is solved. > = > But new problem appeared, there are only three descriptions in legend= instead of four. > = > The problem is in ChartTableModel.cpp line 176. That problem should also be fixed now in trunk. - Johannes ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5288/#review7539 ----------------------------------------------------------- On 2010-09-09 08:35:59, Matus Hanzes wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5288/ > ----------------------------------------------------------- > = > (Updated 2010-09-09 08:35:59) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Wrong legend is shown in kpresenter pie chart. > = > Chart shape is using Legend::buildLegend function to set legend data. > To get the label data KDChartModel::headerData function is called, which = is using DataSet::categoryData function. > The problem is that categoryData string is empty. > = > This fix sets the category data string to proper value. > = > Test file: > tests/kofficetests/odf/charts/Piecharts.odp > = > = > Diffs > ----- > = > trunk/koffice/plugins/chartshape/Axis.cpp 1173269 = > trunk/koffice/plugins/chartshape/PlotArea.cpp 1173269 = > = > Diff: http://svn.reviewboard.kde.org/r/5288/diff > = > = > Testing > ------- > = > = > Thanks, > = > Matus > = > --===============7322037598370815488== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5288/

On September 11th, 2010, 11:32 a.m., Johann= es Simon wrote:

I recentl=
y committed a patch [1] in trunk that should fix this. I also checked the t=
est file you mentioned, and it looks good to me. Can you verify?

[1] http://websvn.kde.org/?view=3Drevision&revision=3D1174138

On September 14th, 2010, 6:43 a.m., Matus Hanzes wrote:

Thanks fo=
r solving it. I have tested it on 1174897.

The legend looks better now and the previous problem is solved.

But new problem appeared, there are only three descriptions in legend inste=
ad of four.

The problem is in ChartTableModel.cpp line 176.
That proble=
m should also be fixed now in trunk.

- Johannes


On September 9th, 2010, 8:35 a.m., Matus Hanzes wrote:

Review request for KOffice.
By Matus Hanzes.

Updated 2010-09-09 08:35:59

Descripti= on 

Wrong legend is shown in kpresenter pie chart.

Chart shape is using Legend::buildLegend function to set legend data.
To get the label data KDChartModel::headerData function is called, which is=
 using DataSet::categoryData function.
The problem is that categoryData string is empty.

This fix sets the category data string to proper value.

Test file:
tests/kofficetests/odf/charts/Piecharts.odp

Diffs=

  • trunk/koffice/plugins/chartshape/Axis.cpp = (1173269)
  • trunk/koffice/plugins/chartshape/PlotArea.cpp (1173269)

View Diff
--===============7322037598370815488==-- --===============1421411825== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1421411825==--