On September 23rd, 2010, 3:16 p.m., Thomas Zander wrote:

trunk/koffice/libs/odf/KoGenStyle.h (Diff revision 1)
public:
		398	if (type == DefaultType) {

What is this part about?

On September 23rd, 2010, 3:22 p.m., Marijn Kruisselbrink wrote:

This is to mimic the behavior of the addProperty methods. When you add a property with type==DefaultType, it is actually added with type=m_propertyType, so this results in that same behavior on lookup.

On September 24th, 2010, 8:56 a.m., Thomas Zander wrote:

Ok, makes sense.
Please document that in the API docs for this new public method.
And I think we should not have the DefaultType as default as that makes it a not-very-conventional getter (which leads to confusing API). So could you remove the (= DefaultType) in the method signature?

I don't think that the alternative of having a getter that is not symmetrical with the setter (where the setter has the same default parameter value) would be any less confusing.
If I can set something with addProperty() without having to specify a type, I'd expect to be able to get that property again without having to specify a type as well.

- Marijn

On September 23rd, 2010, 2:31 p.m., Marijn Kruisselbrink wrote:

This patch makes the attribute() and property() methods in KoGenStyle public instead of private. The main use-case for this class is of course only to set properies and attributes, then insert styles in a KoGenStyles and forget about the actual contents of the style, but sometimes when creating odf files it is useful to be able to later lookup properties of earlier generated styles, without having to double-store that information.
For example in the xlsx filter this is used because the cell style for merged cells is stored in one cell style in odf, but in the xlsx file it is a combination of properties from the cell styles for all cells that are merged. With this change I can simply merge the cell styles when I know that cells are merged, without having to keep the cell-styles around in another format than the KoGenStyle that already contains all relevant information anyway.