This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5431/

On September 23rd, 2010, 3:16 p.m., Thomas = Zander wrote:

= = =
trunk/koffice/lib= s/odf/KoGenStyle.h (Diff revision 1)
public:
398
        if (type =3D=3D DefaultType) {
What is t=
his part about?

trunk/koffice/lib= s/odf/KoGenStyle.h (Diff revision 1)
public:
		398	if (type =3D=3D DefaultType) {

On September 23rd, 2010, 3:22 p.m., Marijn Kruisselbrink wrote:<= /p>

This is t=
o mimic the behavior of the addProperty methods. When you add a property wi=
th type=3D=3DDefaultType, it is actually added with type=3Dm_propertyType, =
so this results in that same behavior on lookup.

On September 24th, 2010, 8:56 a.m., Thomas Zander wrote:

Ok, makes=
 sense.
Please document that in the API docs for this new public method.
And I think we should not have the DefaultType as default as that makes it =
a not-very-conventional getter (which leads to confusing API). So could you=
 remove the (=3D DefaultType) in the method signature?

I don't think that the alternative of having a getter that is no=
t symmetrical with the setter (where the setter has the same default parame=
ter value) would be any less confusing.
If I can set something with addProperty() without having to specify a type,=
 I'd expect to be able to get that property again without having to spe=
cify a type as well.

- Marijn

On September 23rd, 2010, 2:31 p.m., Marijn Kruisselbrink wrote:

Review request for KOffice.

By Marijn Kruisselbrink.

Updated 2010-09-23 14:31:27

Descripti= on

This patch makes the attribute() and property() methods in K=
oGenStyle public instead of private. The main use-case for this class is of=
 course only to set properies and attributes, then insert styles in a KoGen=
Styles and forget about the actual contents of the style, but sometimes whe=
n creating odf files it is useful to be able to later lookup properties of =
earlier generated styles, without having to double-store that information.
For example in the xlsx filter this is used because the cell style for merg=
ed cells is stored in one cell style in odf, but in the xlsx file it is a c=
ombination of properties from the cell styles for all cells that are merged=
. With this change I can simply merge the cell styles when I know that cell=
s are merged, without having to keep the cell-styles around in another form=
at than the KoGenStyle that already contains all relevant information anywa=
y.

Diffs=

trunk/koffice/libs/odf/KoGenStyle.h (11781= 91)

View Diff