From koffice-devel Fri Sep 24 08:58:02 2010 From: "Thomas Zander" Date: Fri, 24 Sep 2010 08:58:02 +0000 To: koffice-devel Subject: Re: Review Request: Make the attribute() and property() methods in Message-Id: <20100924085802.32154.29885 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128531873029198 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1055041154==" --===============1055041154== Content-Type: multipart/alternative; boundary="===============2536960836761784779==" --===============2536960836761784779== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5431/#review7740 ----------------------------------------------------------- Ship it! Eventually all methods should be moved to the private as this library shoul= d eventually become BC (since otherwise flake would not be BC by dependency= ) but, sure, its not a requirement for this review. If you can implement the suggestions below; please feel free to commit. - Thomas On 2010-09-23 14:31:27, Marijn Kruisselbrink wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5431/ > ----------------------------------------------------------- > = > (Updated 2010-09-23 14:31:27) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > This patch makes the attribute() and property() methods in KoGenStyle pub= lic instead of private. The main use-case for this class is of course only = to set properies and attributes, then insert styles in a KoGenStyles and fo= rget about the actual contents of the style, but sometimes when creating od= f files it is useful to be able to later lookup properties of earlier gener= ated styles, without having to double-store that information. > For example in the xlsx filter this is used because the cell style for me= rged cells is stored in one cell style in odf, but in the xlsx file it is a= combination of properties from the cell styles for all cells that are merg= ed. With this change I can simply merge the cell styles when I know that ce= lls are merged, without having to keep the cell-styles around in another fo= rmat than the KoGenStyle that already contains all relevant information any= way. > = > = > Diffs > ----- > = > trunk/koffice/libs/odf/KoGenStyle.h 1178191 = > = > Diff: http://svn.reviewboard.kde.org/r/5431/diff > = > = > Testing > ------- > = > = > Thanks, > = > Marijn > = > --===============2536960836761784779== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5431/

Ship it!

Eventually=
 all methods should be moved to the private as this library should eventual=
ly become BC (since otherwise flake would not be BC by dependency) but, sur=
e, its not a requirement for this review.

If you can implement the suggestions below; please feel free to commit.
 








- Thomas




On September 23rd, 2010, 2:31 p.m., Marijn Kruisselbrink wrote:







 
  

Review request for KOffice.
By Marijn Kruisselbrink.


Updated 2010-09-23 14:31:27




Descripti=
on 

 
  
   This patch makes the attribute() and property() methods in K=
oGenStyle public instead of private. The main use-case for this class is of=
 course only to set properies and attributes, then insert styles in a KoGen=
Styles and forget about the actual contents of the style, but sometimes whe=
n creating odf files it is useful to be able to later lookup properties of =
earlier generated styles, without having to double-store that information.
For example in the xlsx filter this is used because the cell style for merg=
ed cells is stored in one cell style in odf, but in the xlsx file it is a c=
ombination of properties from the cell styles for all cells that are merged=
. With this change I can simply merge the cell styles when I know that cell=
s are merged, without having to keep the cell-styles around in another form=
at than the KoGenStyle that already contains all relevant information anywa=
y.
  
 






Diffs=
 


 trunk/koffice/libs/odf/KoGenStyle.h (11781=
91)



View Diff

--===============2536960836761784779==-- --===============1055041154== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1055041154==--