On September 23rd, 2010, 3:16 p.m., Thomas Zander wrote:

Making the methods non-private makes me think we should no longer have those methods be inlined as that would mean the implementation would be copied in the library of all users.
Can you please move the implementation to the cpp file?

The various setters of this class are also all inlined, so not sure if it would actually gain us much by changing that for the getters. (and I assume there was a good reason to make most of the methods in this class inlined in the first place, otherwise they could of course all be move to the cpp file).

On September 23rd, 2010, 3:16 p.m., Thomas Zander wrote:

trunk/koffice/libs/odf/KoGenStyle.h (Diff revision 1)
public:
		398	if (type == DefaultType) {

What is this part about?

This is to mimic the behavior of the addProperty methods. When you add a property with type==DefaultType, it is actually added with type=m_propertyType, so this results in that same behavior on lookup.

- Marijn

On September 23rd, 2010, 2:31 p.m., Marijn Kruisselbrink wrote:

This patch makes the attribute() and property() methods in KoGenStyle public instead of private. The main use-case for this class is of course only to set properies and attributes, then insert styles in a KoGenStyles and forget about the actual contents of the style, but sometimes when creating odf files it is useful to be able to later lookup properties of earlier generated styles, without having to double-store that information.
For example in the xlsx filter this is used because the cell style for merged cells is stored in one cell style in odf, but in the xlsx file it is a combination of properties from the cell styles for all cells that are merged. With this change I can simply merge the cell styles when I know that cells are merged, without having to keep the cell-styles around in another format than the KoGenStyle that already contains all relevant information anyway.