[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: text-on-shapes and EnhancedPathShape's text-areas attribute
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2010-09-23 2:37:16
Message-ID: 201009230437.17310.t.zachmann () zagge ! de
[Download RAW message or body]

On Wednesday 22 September 2010 08:46:30 Thomas Zander wrote:
> On Wednesday 22. September 2010 05.29.17 Thorsten Zachmann wrote:
> > On Wednesday 22 September 2010 00:01:24 Marijn Kruisselbrink wrote:
> > > On Tuesday 21 September 2010 22:10:40 Thomas Zander wrote:
> > > > On Tuesday 21. September 2010 20.45.35 Marijn Kruisselbrink wrote:
> > > > > Hmm, okay. Then I guess we'll just have to hope we'll still
> > > > > remember all the places we made use of the assumption that never
> > > > > more than one decorator will exist if we ever do come up with a
> > > > > usecase for multiple decorators on one shape.
> > > > 
> > > > Oh, we will have multiple decorators for one shape. Thats clear in my
> > > > mind. Sorry if I was not being clear.
> > > > The point that I wanted to make is that if you decorate Shape S1 with
> > > > D1 and decorate D1 with D2 which is a TextOnShape based docorator,
> > > > then whatever S1 looks like is completely irrelevant to D2.
> > > > Hence you only need to every do one parent().
> > > 
> > > Hmm, okay. I'm not entirely convinced, but for now it will do.
> > 
> > If I understood Thomas correctly there can be multiple different
> > decorators for a shape. That means that in the scenario described above
> > your patch will not work as
> > 
> > +    KoTextOnShapeContainer* tosContainer =
> > dynamic_cast<KoTextOnShapeContainer*>(parent());
> > 
> > will fail and thus the functionality you are implementing will not work
> > if D2 is the KoTextOnShapeContainer as it is not the parent in that
> > case.
> 
> And my point was that this is correct and expected.

Looks like you lost me here. Why is it expected that the feature Marijn has 
described should no longer work if there is an additional container between 
the shape and the KoTextOnShapeContainer? It is still the EnhancedPathShape 
that defines the where the area is in which the text should be put and that 
needs to be updated when to it changes.

Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]