'Re: Review Request: Removed additional check'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Removed additional check
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-09-19 11:44:52
Message-ID: 20100919114452.3868.36848 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5366/#review7683
-----------------------------------------------------------

Ship it!

Tested with kspread, kword and kpresenter and found no adverse effects, and does fix \
autoscrolling in Krita.

- Boudewijn

On 2010-09-16 08:26:48, Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5366/
> -----------------------------------------------------------
> 
> (Updated 2010-09-16 08:26:48)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> The range is guaranteed by the scroll bars, so it is excessive. More than that, \
> this check breaks auto-scrolling in Vast Scrolling mode. BUG:251361
> 
> 
> This addresses bug 251361.
> https://bugs.kde.org/show_bug.cgi?id=251361
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/libs/flake/KoCanvasControllerWidget.cpp 1175950 
> 
> Diff: http://svn.reviewboard.kde.org/r/5366/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5366/">http://svn.reviewboard.kde.org/r/5366/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with kspread, \
kword and kpresenter and found no adverse effects, and does fix autoscrolling in \
Krita.</pre>  <br />

<p>- Boudewijn</p>

<br />
<p>On September 16th, 2010, 8:26 a.m., Dmitry Kazakov wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Dmitry Kazakov.</div>

<p style="color: grey;"><i>Updated 2010-09-16 08:26:48</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The range is guaranteed by the scroll bars, so it is excessive. More \
than that, this check breaks auto-scrolling in Vast Scrolling mode. BUG:251361</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=251361">251361</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/libs/flake/KoCanvasControllerWidget.cpp <span style="color: \
grey">(1175950)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5366/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 