From koffice-devel Fri Sep 17 22:09:59 2010 From: Johannes Simon Date: Fri, 17 Sep 2010 22:09:59 +0000 To: koffice-devel Subject: Re: koffice Message-Id: X-MARC-Message: https://marc.info/?l=koffice-devel&m=128476145628641 Its intended to fix bugs, but its indeed on the borderline. That's why I put it up on reviewboard. I got "Ship it!" two times, so I did. Am 18.09.2010 um 00:03 schrieb Marijn Kruisselbrink: > Isn't this is a new feature, and as such should not have been committed while > koffice is in hard feature freeze? > > Marijn > > On Saturday 18 September 2010 00:02:04 Johannes Simon wrote: >> SVN commit 1176523 by jsimon: >> >> Allow chart to have multiple data tables. >> >> A TableSource is introduced which is used to manage all tables as >> name/model pairs. The CellRegion is changed to store a Table* pointer >> ("handed out" by TableSource) instead ot just the sheet name. >> >> The ChartProxyModel is adapted to accommodate these changes. >> ChartProxyModel::slotRows/Columns/Inserted/Removes() are obsolete, remove >> them. Another commit will change the ChartTableEditor to take care of >> handling removals and insertions in the internal data table, as this is to >> be handled as a special case. >> >> Various test cases have been written to cover these changes and are in this >> commit or will be committet later. >> >> See http://svn.reviewboard.kde.org/r/5373/ >> >> M +28 -7 interfaces/KoChartInterface.h >> M +7 -12 kspread/chart/ChartDatabaseSelector.cpp >> M +13 -10 plugins/chartshape/Axis.cpp >> M +11 -2 plugins/chartshape/Axis.h >> M +2 -0 plugins/chartshape/CMakeLists.txt >> M +32 -27 plugins/chartshape/CellRegion.cpp >> M +10 -8 plugins/chartshape/CellRegion.h >> M +26 -12 plugins/chartshape/ChartConfigWidget.cpp >> M +5 -5 plugins/chartshape/ChartConfigWidget.h >> M +78 -338 plugins/chartshape/ChartProxyModel.cpp >> M +53 -32 plugins/chartshape/ChartProxyModel.h >> M +64 -73 plugins/chartshape/ChartShape.cpp >> M +56 -8 plugins/chartshape/ChartShape.h >> M +9 -4 plugins/chartshape/ChartShapeFactory.cpp >> M +4 -0 plugins/chartshape/ChartTableModel.cpp >> M +20 -20 plugins/chartshape/ChartTool.cpp >> M +5 -5 plugins/chartshape/ChartTool.h >> M +19 -150 plugins/chartshape/DataSet.cpp >> M +1 -12 plugins/chartshape/DataSet.h >> A plugins/chartshape/OdfLoadingHelper.h [License: LGPL >> (v2+)] M +18 -9 plugins/chartshape/PlotArea.cpp >> A plugins/chartshape/TableSource.cpp [License: LGPL (v2+)] >> A plugins/chartshape/TableSource.h [License: LGPL (v2+)] >> M +6 -2 plugins/chartshape/dialogs/TableEditorDialog.cpp >> M +2 -0 plugins/chartshape/dialogs/TableEditorDialog.h >> M +4 -0 plugins/chartshape/kchart_global.h >> A plugins/chartshape/tests (directory) >> A plugins/chartshape/tests/CMakeLists.txt >> A plugins/chartshape/tests/ModelObserver.cpp [License: LGPL >> (v2+)] A plugins/chartshape/tests/ModelObserver.h [License: >> LGPL (v2+)] A plugins/chartshape/tests/TestCellRegion.cpp >> [License: LGPL (v2+)] A >> plugins/chartshape/tests/TestCellRegion.h [License: LGPL (v2+)] A >> plugins/chartshape/tests/TestDataSet.cpp [License: LGPL (v2+)] A >> plugins/chartshape/tests/TestDataSet.h [License: LGPL (v2+)] A >> plugins/chartshape/tests/TestKDChartModel.cpp [License: LGPL >> (v2+)] A plugins/chartshape/tests/TestKDChartModel.h >> [License: LGPL (v2+)] A >> plugins/chartshape/tests/TestProxyModel.cpp [License: LGPL (v2+)] A >> plugins/chartshape/tests/TestProxyModel.h [License: LGPL (v2+)] A >> plugins/chartshape/tests/TestTableSource.cpp [License: LGPL >> (v2+)] A plugins/chartshape/tests/TestTableSource.h [License: >> LGPL (v2+)] >> >> >> http://websvn.kde.org/?view=rev&revision=1176523 > > _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel