[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Review Request: Filter must filter entire layer, not only image bounds
From: "Dmitry Kazakov" <dimula73 () gmail ! com>
Date: 2010-09-14 20:55:13
Message-ID: 20100914205513.25754.88530 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5347/
-----------------------------------------------------------
Review request for KOffice.
Summary
-------
This patch makes masks' selection to cover entire layer by default. This is=
achieved with making KisDefaultBounds polymorphic, so we can override it w=
ith KisSelectionDefaultBounds.
How to check: Filter->[select any filter]->Apply; Then move a layer and che=
ck if the data outside borders of image was filtered as well.
Diffs
-----
/trunk/koffice/krita/image/kis_default_bounds.h 1174371 =
/trunk/koffice/krita/image/kis_default_bounds.cpp 1174371 =
/trunk/koffice/krita/image/kis_group_layer.cc 1174371 =
/trunk/koffice/krita/image/kis_image.cc 1174371 =
/trunk/koffice/krita/image/kis_mask.cc 1175117 =
/trunk/koffice/krita/image/kis_paint_device.h 1174371 =
/trunk/koffice/krita/image/kis_paint_device.cc 1175116 =
/trunk/koffice/krita/image/kis_paint_layer.cc 1174371 =
/trunk/koffice/krita/image/kis_pixel_selection.h 1174371 =
/trunk/koffice/krita/image/kis_pixel_selection.cpp 1174371 =
/trunk/koffice/krita/image/kis_selection.h 1174371 =
/trunk/koffice/krita/image/kis_selection.cc 1174371 =
/trunk/koffice/krita/image/kis_selection_based_layer.cpp 1174371 =
/trunk/koffice/krita/image/tests/kis_filter_mask_test.cpp 1174371 =
/trunk/koffice/krita/image/tests/kis_pixel_selection_test.cpp 1174371 =
/trunk/koffice/krita/image/tests/kis_selection_test.h 1174371 =
/trunk/koffice/krita/image/tests/kis_selection_test.cpp 1174371 =
/trunk/koffice/krita/ui/dialogs/kis_dlg_filter.cpp 1174371 =
/trunk/koffice/krita/ui/kis_filter_handler.cc 1174371 =
Diff: http://svn.reviewboard.kde.org/r/5347/diff
Testing
-------
Need help with testing ;)
Thanks,
Dmitry
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5347/">http://svn.reviewboard.kde.org/r/5347/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Dmitry Kazakov.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch makes masks' selection to cover entire layer by default. \
This is achieved with making KisDefaultBounds polymorphic, so we can override it with \
KisSelectionDefaultBounds.
How to check: Filter->[select any filter]->Apply; Then move a layer and check \
if the data outside borders of image was filtered as well.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Need help with testing ;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/krita/image/kis_default_bounds.h <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/kis_default_bounds.cpp <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/kis_group_layer.cc <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/kis_image.cc <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/kis_mask.cc <span style="color: \
grey">(1175117)</span></li>
<li>/trunk/koffice/krita/image/kis_paint_device.h <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/kis_paint_device.cc <span style="color: \
grey">(1175116)</span></li>
<li>/trunk/koffice/krita/image/kis_paint_layer.cc <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/kis_pixel_selection.h <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/kis_pixel_selection.cpp <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/kis_selection.h <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/kis_selection.cc <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/kis_selection_based_layer.cpp <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/tests/kis_filter_mask_test.cpp <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/tests/kis_pixel_selection_test.cpp <span \
style="color: grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/tests/kis_selection_test.h <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/image/tests/kis_selection_test.cpp <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/ui/dialogs/kis_dlg_filter.cpp <span style="color: \
grey">(1174371)</span></li>
<li>/trunk/koffice/krita/ui/kis_filter_handler.cc <span style="color: \
grey">(1174371)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5347/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic