[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: fix scaling of grouped shapes
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-09-14 9:05:00
Message-ID: 20100914090500.7724.16074 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5231/#review7597
-----------------------------------------------------------
Ship it!
Thanks Adam, good simple fix :) I love those kind.
If you can fix the QSize -> QSizeF issue then please commit. The second issue is a \
'would be nice to fix', but its more as a "for the next time" as you spent enough \
time on this issue already.
/trunk/koffice/libs/flake/KoShapeGroup.cpp
<http://svn.reviewboard.kde.org/r/5231/#comment7757>
You meant QSizeF here, I guess.
/trunk/koffice/libs/flake/tests/TestShapeContainer.cpp
<http://svn.reviewboard.kde.org/r/5231/#comment7758>
In this test you use 'new' often; but you never delete any of the stuff you new.
For unit tests we tend to just create shapes etc on the stack to avoid loosing \
memory. Its not *really* a problem as tests are supposed to not run very long, but \
its good practice.
- Thomas
On 2010-09-13 22:02:12, Adam C. wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5231/
> -----------------------------------------------------------
>
> (Updated 2010-09-13 22:02:12)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> this patch intends to fix a bug, where after scaling an image with falke shapes in \
> krita, the shapes appeared in a wrong position.
>
> This addresses bug 227512.
> https://bugs.kde.org/show_bug.cgi?id=227512
>
>
> Diffs
> -----
>
> /trunk/koffice/libs/flake/tests/TestShapeContainer.h 1175005
> /trunk/koffice/libs/flake/tests/TestShapeContainer.cpp 1175005
> /trunk/koffice/libs/flake/KoShapeGroup.h 1174977
> /trunk/koffice/libs/flake/KoShapeGroup.cpp 1174977
>
> Diff: http://svn.reviewboard.kde.org/r/5231/diff
>
>
> Testing
> -------
>
> tested with the file provided in bugreport and with a custom file
>
>
> Thanks,
>
> Adam
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5231/">http://svn.reviewboard.kde.org/r/5231/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks Adam, good simple \
fix :) I love those kind.
If you can fix the QSize -> QSizeF issue then please commit. The second issue is \
a 'would be nice to fix', but its more as a "for the next time" as \
you spent enough time on this issue already.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5231/diff/3/?file=35792#file35792line59" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/koffice/libs/flake/KoShapeGroup.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">QSizeF KoShapeGroup::size() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">59</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">QSize</span><span class="p">(</span><span \
class="mi">0</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You meant \
QSizeF here, I guess.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5231/diff/3/?file=35794#file35794line109" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/libs/flake/tests/TestShapeContainer.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void TestShapeContainer::testScaling()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">109</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KoShape</span> <span class="o">*</span><span class="n">shape1</span> <span \
class="o">=</span> <span class="k">new</span> <span class="n">MockShape</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In this \
test you use 'new' often; but you never delete any of the stuff you new. For \
unit tests we tend to just create shapes etc on the stack to avoid loosing memory. \
Its not *really* a problem as tests are supposed to not run very long, but its good \
practice.</pre> </div>
<br />
<p>- Thomas</p>
<br />
<p>On September 13th, 2010, 10:02 p.m., Adam C. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Adam C..</div>
<p style="color: grey;"><i>Updated 2010-09-13 22:02:12</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this patch intends to fix a bug, where after scaling an image with falke \
shapes in krita, the shapes appeared in a wrong position.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested with the file provided in bugreport and with a custom file</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=227512">227512</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/libs/flake/tests/TestShapeContainer.h <span style="color: \
grey">(1175005)</span></li>
<li>/trunk/koffice/libs/flake/tests/TestShapeContainer.cpp <span style="color: \
grey">(1175005)</span></li>
<li>/trunk/koffice/libs/flake/KoShapeGroup.h <span style="color: \
grey">(1174977)</span></li>
<li>/trunk/koffice/libs/flake/KoShapeGroup.cpp <span style="color: \
grey">(1174977)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5231/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic