[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Re-do text-on-shape loading more specifically
From: "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date: 2010-09-12 6:16:06
Message-ID: 20100912061606.31767.45174 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5301/#review7551
-----------------------------------------------------------
Ship it!
Looks good. Please commit after removing the comment. =
Note when testing this I found out that resizing a shape will let the text =
shape and a path shape no longer be at the same position. The text gets res=
ized correctly while the position of the path shapes gets wrong on resizing=
. This problem can be sen with the following document: http://www.zagge.de/=
files/layer_test.odg. Should I open a bug report for that?
trunk/koffice/karbon/common/KarbonDocument.cpp
<http://svn.reviewboard.kde.org/r/5301/#comment7714>
looks like this should have not been part of the patch. please remove.
- Thorsten
On 2010-09-09 21:21:53, Thomas Zander wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5301/
> -----------------------------------------------------------
> =
> (Updated 2010-09-09 21:21:53)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> In ODF not every shape-type can load text-on-shape and so its more
> correct to load it only from those that can possibly hold this info.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/karbon/common/KarbonDocument.cpp 1173509 =
> trunk/koffice/libs/flake/KoConnectionShape.cpp 1173509 =
> trunk/koffice/libs/flake/KoPathShape.cpp 1173509 =
> trunk/koffice/libs/flake/KoShapeRegistry.cpp 1173509 =
> trunk/koffice/libs/flake/KoTextOnShapeContainer.h 1173509 =
> trunk/koffice/libs/flake/KoTextOnShapeContainer.cpp 1173509 =
> trunk/koffice/plugins/pathshapes/ellipse/EllipseShape.cpp 1173509 =
> trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 117=
3509 =
> trunk/koffice/plugins/pathshapes/rectangle/RectangleShape.cpp 1173509 =
> trunk/koffice/plugins/pathshapes/star/StarShape.cpp 1173509 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5301/diff
> =
> =
> Testing
> -------
> =
> Load doc from bug 184546
> =
> =
> Thanks,
> =
> Thomas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5301/">http://svn.reviewboard.kde.org/r/5301/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. Please \
commit after removing the comment.
Note when testing this I found out that resizing a shape will let the text shape and \
a path shape no longer be at the same position. The text gets resized correctly while \
the position of the path shapes gets wrong on resizing. This problem can be sen with \
the following document: http://www.zagge.de/files/layer_test.odg. Should I open a bug \
report for that?</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5301/diff/2/?file=35581#file35581line239" style="color: black; font-weight: \
bold; text-decoration: underline;">trunk/koffice/karbon/common/KarbonDocument.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KarbonDocument::loadOasis(const KoXmlElement &element, KoShapeLoadingContext \
&context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">239</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> \
<span class="s">"shape"</span> <span class="o"><<</span> <span \
class="n">shape</span> <span class="o"><<</span> <span \
class="n">shape</span><span class="o">-></span><span class="n">parent</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks like \
this should have not been part of the patch. please remove.</pre> </div>
<br />
<p>- Thorsten</p>
<br />
<p>On September 9th, 2010, 9:21 p.m., Thomas Zander wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Thomas Zander.</div>
<p style="color: grey;"><i>Updated 2010-09-09 21:21:53</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In ODF not every shape-type can load text-on-shape and so its more \
correct to load it only from those that can possibly hold this info.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Load doc from bug 184546</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/karbon/common/KarbonDocument.cpp <span style="color: \
grey">(1173509)</span></li>
<li>trunk/koffice/libs/flake/KoConnectionShape.cpp <span style="color: \
grey">(1173509)</span></li>
<li>trunk/koffice/libs/flake/KoPathShape.cpp <span style="color: \
grey">(1173509)</span></li>
<li>trunk/koffice/libs/flake/KoShapeRegistry.cpp <span style="color: \
grey">(1173509)</span></li>
<li>trunk/koffice/libs/flake/KoTextOnShapeContainer.h <span style="color: \
grey">(1173509)</span></li>
<li>trunk/koffice/libs/flake/KoTextOnShapeContainer.cpp <span style="color: \
grey">(1173509)</span></li>
<li>trunk/koffice/plugins/pathshapes/ellipse/EllipseShape.cpp <span style="color: \
grey">(1173509)</span></li>
<li>trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <span \
style="color: grey">(1173509)</span></li>
<li>trunk/koffice/plugins/pathshapes/rectangle/RectangleShape.cpp <span \
style="color: grey">(1173509)</span></li>
<li>trunk/koffice/plugins/pathshapes/star/StarShape.cpp <span style="color: \
grey">(1173509)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5301/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic