'Re: Review Request: Chart legend fix for pie charts'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Chart legend fix for pie charts
From:       "Matus Hanzes" <matus.hanzes () ixonos ! com>
Date:       2010-09-09 8:35:59
Message-ID: 20100909083559.12677.98810 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5288/
-----------------------------------------------------------

(Updated 2010-09-09 08:35:59.139730)

Review request for KOffice.

Changes
-------

Johannes design used.

Summary
-------

Wrong legend is shown in kpresenter pie chart.

Chart shape is using Legend::buildLegend function to set legend data.
To get the label data KDChartModel::headerData function is called, which is=
 using DataSet::categoryData function.
The problem is that categoryData string is empty.

This fix sets the category data string to proper value.

Test file:
tests/kofficetests/odf/charts/Piecharts.odp

Diffs (updated)
-----

  trunk/koffice/plugins/chartshape/Axis.cpp 1173269 =

  trunk/koffice/plugins/chartshape/PlotArea.cpp 1173269 =

Diff: http://svn.reviewboard.kde.org/r/5288/diff

Testing
-------

Thanks,

Matus

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5288/">http://svn.reviewboard.kde.org/r/5288/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Matus Hanzes.</div>

<p style="color: grey;"><i>Updated 2010-09-09 08:35:59.139730</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Johannes design used.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Wrong legend is shown in kpresenter pie chart.

Chart shape is using Legend::buildLegend function to set legend data.
To get the label data KDChartModel::headerData function is called, which is using \
DataSet::categoryData function. The problem is that categoryData string is empty.

This fix sets the category data string to proper value.

Test file:
tests/kofficetests/odf/charts/Piecharts.odp</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/plugins/chartshape/Axis.cpp <span style="color: \
grey">(1173269)</span></li>

 <li>trunk/koffice/plugins/chartshape/PlotArea.cpp <span style="color: \
grey">(1173269)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5288/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 