'Review Request: Fix centering on image document initialization'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Fix centering on image document initialization
From:       "Dmitry Kazakov" <dimula73 () gmail ! com>
Date:       2010-09-06 17:13:38
Message-ID: 20100906171338.5955.44509 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5273/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

BUG:230970

Added an option to KoZoomController to workaroung a hack in KoCanvasControllerWidget. \
recalculateCenter option set to false dirties preferredCenterFraction when called the \
first time.

This addresses bug 230970.
    https://bugs.kde.org/show_bug.cgi?id=230970

Diffs
-----

  /trunk/koffice/krita/ui/kis_zoom_manager.cc 1171532 
  /trunk/koffice/libs/flake/KoCanvasControllerWidget.cpp 1171859 
  /trunk/koffice/libs/widgets/KoZoomController.h 1171532 
  /trunk/koffice/libs/widgets/KoZoomController.cpp 1171532 

Diff: http://svn.reviewboard.kde.org/r/5273/diff

Testing
-------

Thanks,

Dmitry

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5273/">http://svn.reviewboard.kde.org/r/5273/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Dmitry Kazakov.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">BUG:230970

Added an option to KoZoomController to workaroung a hack in KoCanvasControllerWidget. \
recalculateCenter option set to false dirties preferredCenterFraction when called the \
first time.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=230970">230970</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/krita/ui/kis_zoom_manager.cc <span style="color: \
grey">(1171532)</span></li>

 <li>/trunk/koffice/libs/flake/KoCanvasControllerWidget.cpp <span style="color: \
grey">(1171859)</span></li>

 <li>/trunk/koffice/libs/widgets/KoZoomController.h <span style="color: \
grey">(1171532)</span></li>

 <li>/trunk/koffice/libs/widgets/KoZoomController.cpp <span style="color: \
grey">(1171532)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5273/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 