'Fwd: Review Request: fix bug with ungroup command'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Fwd: Review Request: fix bug with ungroup command
From:       "Adam C." <nospam () xibo ! at>
Date:       2010-09-02 1:13:14
Message-ID: op.vidsccvv2qq4ze () damdam-laptop
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

------- Forwarded message -------
From: "Adam C." <bugs_kde_org@xibo.at>
To: "Adam C." <bugs_kde_org@xibo.at>, KOffice <koffice-devel@kde.org>
Cc:
Subject: Review Request: fix bug with ungroup command
Date: Thu, 02 Sep 2010 03:11:02 +0200
  This is an automatically generated e-mail. To reply, visit:  
http://svn.reviewboard.kde.org/r/5233/

Review request for KOffice.
By Adam C..
Description there is a bug in flake, here are the steps to reproduce it in  
krita:
1. create a new image with some shapes on it
2. group all shapes
3. image menu -> scale to new size, 50%
4. ungroup

now the shapes appear at 25%. the reason is, that the group transform is  
applied in addition to the shape transform. this is incorrect, as far as i  
can tell from the code, because you have to check  
container->inheritsTransform(shape).

i've solved that by copying code from KoShape::absoluteTransformation  
(line 345 and following).

Testing tested with the file from  
https://bugs.kde.org/show_bug.cgi?id=227512 as well as with an own test  
file.

Diffs
/trunk/koffice/libs/flake/commands/KoShapeGroupCommand.cpp (1170431)

View Diff

-- 
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
[Attachment #5 (multipart/related)]

[Attachment #7 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">
<HTML>
<HEAD></HEAD>
<BODY style="font-family:'DejaVu Sans Mono'; font-size:10px"><div><br><br>------- \
Forwarded message -------<br>From: "Adam C." &lt;bugs_kde_org@xibo.at&gt;<br>To: \
"Adam C." &lt;bugs_kde_org@xibo.at&gt;, KOffice \
&lt;koffice-devel@kde.org&gt;<br>Cc:<br>Subject: Review Request: fix bug with ungroup \
command<br>Date: Thu, 02 Sep 2010 03:11:02 +0200<br><br>  <div style="font-family: \
Verdana, Arial, Helvetica, Sans-Serif;">  <table bgcolor="#f9f3c9" width="100%" \
cellpadding="8" style="border: 1px #c9c399 solid;">  <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5233/">http://svn.reviewboard.kde.org/r/5233/</a>
  </td>
    </tr>
   </tbody></table>
   <br>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tbody><tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Adam C..</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tbody><tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">there is a bug in flake, here are the steps to reproduce it in krita: 1. \
create a new image with some shapes on it 2. group all shapes
3. image menu -&gt; scale to new size, 50%
4. ungroup

now the shapes appear at 25%. the reason is, that the group transform is applied in \
addition to the shape transform. this is incorrect, as far as i can tell from the \
code, because you have to check container-&gt;inheritsTransform(shape).

i've solved that by copying code from KoShape::absoluteTransformation (line 345 and \
following). 

</pre>  </td>
 </tr>
</tbody></table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tbody><tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested with the file from https://bugs.kde.org/show_bug.cgi?id=227512 as \
well as with an own test file.</pre>  </td>  </tr>
</tbody></table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/libs/flake/commands/KoShapeGroupCommand.cpp <span style="color: \
grey">(1170431)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5233/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</tbody></table>

  </div>
 <br><br><br><div id="M2Signature"><div>-- </div><div>Using Opera's revolutionary \
e-mail client: <a href="http://www.opera.com/mail/">http://www.opera.com/mail/</a></div></div></div></BODY></HTML>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 