'Re: Review Request: Fixes crash while saving empty document'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fixes crash while saving empty document
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-09-01 13:14:40
Message-ID: 20100901131440.8398.45720 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5210/#review7337
-----------------------------------------------------------

Thanks, good find.
The fix is actually simpler than this, its to no longer cast;
hunk kword/part/KWOdfWriter.cpp 391
-        if (KWord::isAutoGenerated(dynamic_cast<KWTextFrameSet*>(fs)))
+        if (KWord::isAutoGenerated(fs))

Can you test if that works? If so, please commit :)

- Thomas

On 2010-09-01 08:44:32, Mani Chandrasekar wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5210/
> -----------------------------------------------------------
> =

> (Updated 2010-09-01 08:44:32)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> This fixes crash while saving empty document.
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/kword/part/KWOdfWriter.cpp 1170485 =

> =

> Diff: http://reviewboard.kde.org/r/5210/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Mani
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/5210/">http://reviewboard.kde.org/r/5210/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, good find. The \
fix is actually simpler than this, its to no longer cast; hunk \
                kword/part/KWOdfWriter.cpp 391
-        if (KWord::isAutoGenerated(dynamic_cast&lt;KWTextFrameSet*&gt;(fs)))
+        if (KWord::isAutoGenerated(fs))

Can you test if that works? If so, please commit :)</pre>
 <br />

<p>- Thomas</p>

<br />
<p>On September 1st, 2010, 8:44 a.m., Mani Chandrasekar wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Mani Chandrasekar.</div>

<p style="color: grey;"><i>Updated 2010-09-01 08:44:32</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes crash while saving empty document.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/kword/part/KWOdfWriter.cpp <span style="color: \
grey">(1170485)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/5210/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 