[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Patch for SpellChecker that added suggestions for
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2010-08-31 17:19:31
Message-ID: 20100831171931.31233.66737 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5203/#review7315
-----------------------------------------------------------
I have applied and compiled it, but I do not get a list of alternative word=
s in the right-click menu. Did I do something wrong?
In general, do add yourself to the copyright of the files you have substant=
ially changed.
Final note -- today is the last day for feature commits...
/trunk/koffice/plugins/textediting/spellcheck/SpellCheckMenu.h
<http://reviewboard.kde.org/r/5203/#comment7409>
Copyright!
/trunk/koffice/plugins/textediting/spellcheck/SpellCheckMenu.cpp
<http://reviewboard.kde.org/r/5203/#comment7408>
Don't forget the copyright headers.
- Boudewijn
On 2010-08-31 16:59:57, Christoph Goerlich wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5203/
> -----------------------------------------------------------
> =
> (Updated 2010-08-31 16:59:57)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> This patch added a context-menu for the SpellChecker to show Spelling-Sug=
gestions for misspelled words.
> The menu is visible as extension of the right-click context-menu and appe=
ars when Background-SpellChecking is enabled and a misspelled word is right=
-clicked.
> Fixed: on typing words while Background-SpellChecking ranges will added m=
ultiple-duplicated to the AdditionalFormats of the TextBlock, a workaround =
for this is found in 'SpellCheck::finishedRun'.
> =
> =
> Diffs
> -----
> =
> /trunk/koffice/kword/part/kword.rc 1167367 =
> /trunk/koffice/libs/kotext/KoTextEditingPlugin.h 1167367 =
> /trunk/koffice/libs/kotext/KoTextEditingPlugin.cpp 1167367 =
> /trunk/koffice/plugins/textediting/spellcheck/BgSpellCheck.h 1167367 =
> /trunk/koffice/plugins/textediting/spellcheck/BgSpellCheck.cpp 1167367 =
> /trunk/koffice/plugins/textediting/spellcheck/CMakeLists.txt 1167367 =
> /trunk/koffice/plugins/textediting/spellcheck/SpellCheck.h 1167367 =
> /trunk/koffice/plugins/textediting/spellcheck/SpellCheck.cpp 1167367 =
> /trunk/koffice/plugins/textediting/spellcheck/SpellCheckMenu.h PRE-CREA=
TION =
> /trunk/koffice/plugins/textediting/spellcheck/SpellCheckMenu.cpp PRE-CR=
EATION =
> /trunk/koffice/plugins/textshape/TextTool.cpp 1167367 =
> =
> Diff: http://reviewboard.kde.org/r/5203/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Christoph
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5203/">http://reviewboard.kde.org/r/5203/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have applied and \
compiled it, but I do not get a list of alternative words in the right-click menu. \
Did I do something wrong?
In general, do add yourself to the copyright of the files you have substantially \
changed.
Final note -- today is the last day for feature commits...</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5203/diff/1/?file=34890#file34890line1" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/plugins/textediting/spellcheck/SpellCheckMenu.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Copyright!</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5203/diff/1/?file=34891#file34891line1" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/plugins/textediting/spellcheck/SpellCheckMenu.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't \
forget the copyright headers.</pre> </div>
<br />
<p>- Boudewijn</p>
<br />
<p>On August 31st, 2010, 4:59 p.m., Christoph Goerlich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Christoph Goerlich.</div>
<p style="color: grey;"><i>Updated 2010-08-31 16:59:57</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch added a context-menu for the SpellChecker to show \
Spelling-Suggestions for misspelled words. The menu is visible as extension of the \
right-click context-menu and appears when Background-SpellChecking is enabled and a \
misspelled word is right-clicked.
Fixed: on typing words while Background-SpellChecking ranges will added \
multiple-duplicated to the AdditionalFormats of the TextBlock, a workaround for this \
is found in 'SpellCheck::finishedRun'. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kword/part/kword.rc <span style="color: \
grey">(1167367)</span></li>
<li>/trunk/koffice/libs/kotext/KoTextEditingPlugin.h <span style="color: \
grey">(1167367)</span></li>
<li>/trunk/koffice/libs/kotext/KoTextEditingPlugin.cpp <span style="color: \
grey">(1167367)</span></li>
<li>/trunk/koffice/plugins/textediting/spellcheck/BgSpellCheck.h <span style="color: \
grey">(1167367)</span></li>
<li>/trunk/koffice/plugins/textediting/spellcheck/BgSpellCheck.cpp <span \
style="color: grey">(1167367)</span></li>
<li>/trunk/koffice/plugins/textediting/spellcheck/CMakeLists.txt <span style="color: \
grey">(1167367)</span></li>
<li>/trunk/koffice/plugins/textediting/spellcheck/SpellCheck.h <span style="color: \
grey">(1167367)</span></li>
<li>/trunk/koffice/plugins/textediting/spellcheck/SpellCheck.cpp <span style="color: \
grey">(1167367)</span></li>
<li>/trunk/koffice/plugins/textediting/spellcheck/SpellCheckMenu.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/koffice/plugins/textediting/spellcheck/SpellCheckMenu.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/koffice/plugins/textshape/TextTool.cpp <span style="color: \
grey">(1167367)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5203/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic