[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Add option to reverse scroll wheel behavior
From: "Sven Langkamp" <sven.langkamp () gmail ! com>
Date: 2010-08-29 17:52:47
Message-ID: 20100829175247.15336.53215 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-08-29 05:12:08, Thorsten Zachmann wrote:
> > trunk/koffice/libs/flake/KoCanvasControllerWidget.h, line 253
> > <http://reviewboard.kde.org/r/5179/diff/1/?file=34827#file34827line253>
> >
> > Here are some unneeded spaces.
I have added the configuration only in Krita for now. That widget isn't used in \
Krita. Also the canvascontroller is implemented differently in the applications.
- Sven
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5179/#review7260
-----------------------------------------------------------
On 2010-08-28 23:39:35, Sven Langkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5179/
> -----------------------------------------------------------
>
> (Updated 2010-08-28 23:39:35)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> The patch adds an option to reverse the behavior of the wheel event. When set to \
> true the wheel with zoom and with control modifier it will scroll.
>
> Diffs
> -----
>
> trunk/koffice/libs/flake/KoCanvasControllerWidget.h 1168870
> trunk/koffice/libs/flake/KoCanvasControllerWidget.cpp 1168870
>
> Diff: http://reviewboard.kde.org/r/5179/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sven
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5179/">http://reviewboard.kde.org/r/5179/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 29th, 2010, 5:12 a.m., <b>Thorsten \
Zachmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5179/diff/1/?file=34827#file34827line253" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/koffice/libs/flake/KoCanvasControllerWidget.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">253</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">setZoomWithWheel</span><span \
class="p">(</span><span class="n">bool</span> <span class="n">zoom</span><span \
class="p">);</span><span class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here are some unneeded \
spaces. </pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have \
added the configuration only in Krita for now. That widget isn't used in Krita. \
Also the canvascontroller is implemented differently in the applications.</pre> <br \
/>
<p>- Sven</p>
<br />
<p>On August 28th, 2010, 11:39 p.m., Sven Langkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>
<p style="color: grey;"><i>Updated 2010-08-28 23:39:35</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch adds an option to reverse the behavior of the wheel event. \
When set to true the wheel with zoom and with control modifier it will scroll.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/flake/KoCanvasControllerWidget.h <span style="color: \
grey">(1168870)</span></li>
<li>trunk/koffice/libs/flake/KoCanvasControllerWidget.cpp <span style="color: \
grey">(1168870)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5179/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic