--===============0043780682== Content-Type: multipart/alternative; boundary="===============8636398453451454932==" --===============8636398453451454932== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5152/#review7242 ----------------------------------------------------------- Hey, cool fix, thanks! The patch was for one hunk, you supplied 3. I like the one that fixes the b= ug you write about the patch needs a bit more work. Could you update the patch with these fixes? Then it can be committed as fa= r as I can see :) /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp This looks wrong, the code below expects the uniqID to become zero. /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp If you want to follow coding style then you should have the closing bra= ce on the same line as the else; if (foo) { } else { } /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp Good catch; this is indeed a correct fix. Could you also add a = kWarning(32500) << "some message" to make clear that we recovered from a broken input file? - Thomas On 2010-08-26 09:12:32, Miroslav Nohaj wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5152/ > ----------------------------------------------------------- > = > (Updated 2010-08-26 09:12:32) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > This small fix just handles the situation when there's a request to finis= h a bookmark which was not started (i.e. in some strange document). Does no= thing special - just checks if really got the pointer to bookmark (and not = null). > = > = > Diffs > ----- > = > /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1167253 = > = > Diff: http://reviewboard.kde.org/r/5152/diff > = > = > Testing > ------- > = > = > Thanks, > = > Miroslav > = > --===============8636398453451454932== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/5152/ 

Hey, cool =
fix, thanks!

The patch was for one hunk, you supplied 3. I like the one that fixes the b=
ug you write about the patch needs a bit more work.
Could you update the patch with these fixes? Then it can be committed as fa=
r as I can see :)

= =
/trunk/koffice/li= bs/kotext/opendocument/KoTextLoader.cpp (Diff revision 1) 
QString KoTextLoader::createUniqueBookmarkName(KoBookmarkManager* b=
mm, QString bookmarkName, bool isEndMarker)
 

    835
    
                if (uniqID &=
gt; 0) {       // don't go to negative index=
es

  


 





This looks wrong, the code below expects the uniqID to become zero.<=
/pre>
















 =

 =




 

 
  

   
    /trunk/koffice/l=
ibs/kotext/opendocument/KoTextLoader.cpp
    

     (Diff revision 1)

    
   
  

 

 
  


   
void KoTextLoader::loadSpan(const KoXmlElement &element, QTextC=
ursor &cursor, bool *stripLeadingSpace)


  

 

  

    
    

    1016
    
                }

  


 





If you want to follow coding style then you should have the closing =
brace on the same line as the else;
  if (foo) {
  } else {
  }

















 =

 =




 

 
  

   
    /trunk/koffice/l=
ibs/kotext/opendocument/KoTextLoader.cpp
    

     (Diff revision 1)

    
   
  

 

 
  


   
void KoTextLoader::loadSpan(const KoXmlElement &element, QTextC=
ursor &cursor, bool *stripLeadingSpace)


  

 

  

    
    

    1032
    
                    if (startBookmark) {        // s=
et end bookmark only if we got start bookmark (we might not have in case of=
 broken document)

  


 





Good catch; this is indeed a correct fix. Could you also add a =

  kWarning(32500) << "some message"
to make clear that we recovered from a broken input file?









- Thomas






On August 26th, 2010, 9:12 a.m., Miroslav Nohaj wrote:









 

  


Review request for KOffice.


By Miroslav Nohaj.




Updated 2010-08-26 09:12:32






Descripti=
on 



 

  
   
This small fix just handles the situation when there's a=
 request to finish a bookmark which was not started (i.e. in some strange d=
ocument). Does nothing special - just checks if really got the pointer to b=
ookmark (and not null).

  		
 









Diffs=
 


    

 
  • /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp (1167253)
    • 





View Diff





  		
 











  

 



--===============8636398453451454932==--

--===============0043780682==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============0043780682==--