[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix for KWord crash when ending not started
From: "Casper Boemann" <cbr () boemann ! dk>
Date: 2010-08-26 9:19:21
Message-ID: 20100826091921.4879.14888 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5152/#review7221
-----------------------------------------------------------
/trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp
<http://reviewboard.kde.org/r/5152/#comment7340>
why don't write:
--unqId
if (uniqId <0) {
uniqId = 0;
ret = boo ......
- Casper
On 2010-08-26 09:12:32, Miroslav Nohaj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5152/
> -----------------------------------------------------------
>
> (Updated 2010-08-26 09:12:32)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This small fix just handles the situation when there's a request to finish a \
> bookmark which was not started (i.e. in some strange document). Does nothing \
> special - just checks if really got the pointer to bookmark (and not null).
>
> Diffs
> -----
>
> /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1167253
>
> Diff: http://reviewboard.kde.org/r/5152/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Miroslav
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5152/">http://reviewboard.kde.org/r/5152/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5152/diff/1/?file=34653#file34653line838" style="color: black; font-weight: \
bold; text-decoration: \
underline;">/trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QString KoTextLoader::createUniqueBookmarkName(KoBookmarkManager* bmm, QString \
bookmarkName, bool isEndMarker)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">838</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">uniqID</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why \
don't write:
--unqId
if (uniqId <0) {
uniqId = 0;
ret = boo ......
</pre>
</div>
<br />
<p>- Casper</p>
<br />
<p>On August 26th, 2010, 9:12 a.m., Miroslav Nohaj wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Miroslav Nohaj.</div>
<p style="color: grey;"><i>Updated 2010-08-26 09:12:32</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This small fix just handles the situation when there's a request to \
finish a bookmark which was not started (i.e. in some strange document). Does nothing \
special - just checks if really got the pointer to bookmark (and not null).</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(1167253)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5152/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic