[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: patch that fixes some issues with the SpellChecker
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-08-17 19:59:04
Message-ID: 20100817195904.17826.87015 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5054/#review7116
-----------------------------------------------------------
Ship it!
Looks good, apart from the comment below I really like the patch :) Excell=
ent work!
If you can remove those couple of lines then the rest of the patch can be c=
ommitted. I'm afraid the question of how to do a spell check run on startu=
p needs a little more thinking -/ But lets not let that get in the way of =
the rest of the fixes :)
/trunk/koffice/plugins/textshape/TextTool.cpp
<http://reviewboard.kde.org/r/5054/#comment7267>
This code would do a spell check run of the whole document more often t=
han we want.
I think we even get a new spell check run when the tool switches to a n=
ew page to edit the text.
=
Starting a spell-check run from the text tool might not be the best ide=
a. For example there can be more than one view on a document and each view =
has this tool activated.
=
Unfortunately I'm not yet sure how to solve this issue... :(
- Thomas
On 2010-08-16 14:48:19, Christoph Goerlich wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5054/
> -----------------------------------------------------------
> =
> (Updated 2010-08-16 14:48:19)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> This patch fixes some issues on the SpellChecker:
> - when 'Auto Spell Check' is (re-) enabled the whole document will ch=
ecked, and not only the Textblock that have currently the cursor
> - a complete SpellChecking appears also when a document is loaded and=
'Auto Spell Check' enabled, for this i added some lines in TextTool::setSh=
apeData (i'm not sure if this is a good place to do this)
> - also reimplemented 'setDocument' from Koffice2.0, with this functio=
n we disconnect and re- connect the 'documentChanged' signal only when the =
document has replaced
> - fixed: when inserting characters in a document with Background-Spel=
lChecking enabled the underlines of the following previously misspelled wor=
ds didn't shift with the word in the line, except for the first TextBlock
> =
> =
> Diffs
> -----
> =
> /trunk/koffice/plugins/textediting/spellcheck/SpellCheck.h 1160929 =
> /trunk/koffice/plugins/textediting/spellcheck/SpellCheck.cpp 1160929 =
> /trunk/koffice/plugins/textshape/TextTool.cpp 1160929 =
> =
> Diff: http://reviewboard.kde.org/r/5054/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Christoph
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5054/">http://reviewboard.kde.org/r/5054/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, apart from \
the comment below I really like the patch :) Excellent work!
If you can remove those couple of lines then the rest of the patch can be committed. \
I'm afraid the question of how to do a spell check run on startup needs a little \
more thinking -/ But lets not let that get in the way of the rest of the fixes \
:)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5054/diff/1/?file=34065#file34065line720" style="color: black; font-weight: \
bold; text-decoration: underline;">/trunk/koffice/plugins/textshape/TextTool.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
TextTool::setShapeData(KoTextShapeData *data)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">720</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//the following lines are to perform a complete spellcheck after a \
document is loaded depending on the state of 'Auto Spell \
Check'</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This code \
would do a spell check run of the whole document more often than we want. I think we \
even get a new spell check run when the tool switches to a new page to edit the text.
Starting a spell-check run from the text tool might not be the best idea. For example \
there can be more than one view on a document and each view has this tool activated.
Unfortunately I'm not yet sure how to solve this issue... :(</pre>
</div>
<br />
<p>- Thomas</p>
<br />
<p>On August 16th, 2010, 2:48 p.m., Christoph Goerlich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Christoph Goerlich.</div>
<p style="color: grey;"><i>Updated 2010-08-16 14:48:19</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes some issues on the SpellChecker:
- when 'Auto Spell Check' is (re-) enabled the whole document will \
checked, and not only the Textblock that have currently the cursor
- a complete SpellChecking appears also when a document is loaded and 'Auto \
Spell Check' enabled, for this i added some lines in TextTool::setShapeData \
(i'm not sure if this is a good place to do this)
- also reimplemented 'setDocument' from Koffice2.0, with this function we \
disconnect and re- connect the 'documentChanged' signal only when the \
document has replaced
- fixed: when inserting characters in a document with Background-SpellChecking \
enabled the underlines of the following previously misspelled words didn't shift \
with the word in the line, except for the first TextBlock</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/plugins/textediting/spellcheck/SpellCheck.h <span style="color: \
grey">(1160929)</span></li>
<li>/trunk/koffice/plugins/textediting/spellcheck/SpellCheck.cpp <span style="color: \
grey">(1160929)</span></li>
<li>/trunk/koffice/plugins/textshape/TextTool.cpp <span style="color: \
grey">(1160929)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5054/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic