[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Move creation of default tools to initialization
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-08-17 11:49:46
Message-ID: 20100817114946.7541.2496 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5058/#review7106
-----------------------------------------------------------
Ship it!
Looks fine to me, if you can do the one suggestion below then please commit.
trunk/koffice/libs/flake/KoToolRegistry.cpp
<http://reviewboard.kde.org/r/5058/#comment7251>
Can you please move the contents of registerGenericTools method here so=
its not a new method?
=
That way we can avoid having a private method being added to an install=
ed header file.
- Thomas
On 2010-08-17 08:35:48, Dmitry Kazakov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5058/
> -----------------------------------------------------------
> =
> (Updated 2010-08-17 08:35:48)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> This is needed to allow applications to override default tools with their=
own implementation.
> Hardcoded values in KoToolManager::Private::setup() used to lead to incon=
sistent state of the KisToolManager: two buttons were created pointing to t=
he same tool.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/libs/flake/KoToolManager.cpp 1163293 =
> trunk/koffice/libs/flake/KoToolRegistry.h 1163293 =
> trunk/koffice/libs/flake/KoToolRegistry.cpp 1163293 =
> =
> Diff: http://reviewboard.kde.org/r/5058/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Dmitry
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5058/">http://reviewboard.kde.org/r/5058/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me, if you \
can do the one suggestion below then please commit.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5058/diff/1/?file=34075#file34075line51" style="color: black; font-weight: \
bold; text-decoration: underline;">trunk/koffice/libs/flake/KoToolRegistry.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KoToolRegistry::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">51</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">registerGenericTools</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you \
please move the contents of registerGenericTools method here so its not a new method?
That way we can avoid having a private method being added to an installed header \
file.</pre> </div>
<br />
<p>- Thomas</p>
<br />
<p>On August 17th, 2010, 8:35 a.m., Dmitry Kazakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Dmitry Kazakov.</div>
<p style="color: grey;"><i>Updated 2010-08-17 08:35:48</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is needed to allow applications to override default tools with \
their own implementation. Hardcoded values in KoToolManager::Private::setup() used to \
lead to inconsistent state of the KisToolManager: two buttons were created pointing \
to the same tool.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/flake/KoToolManager.cpp <span style="color: \
grey">(1163293)</span></li>
<li>trunk/koffice/libs/flake/KoToolRegistry.h <span style="color: \
grey">(1163293)</span></li>
<li>trunk/koffice/libs/flake/KoToolRegistry.cpp <span style="color: \
grey">(1163293)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5058/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic