[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Small KWord fix for continuous pages adding
From: "Carlos Licea" <carlos_licea () hotmail ! com>
Date: 2010-08-11 19:23:46
Message-ID: 20100811192346.26774.4383 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-28 11:21:31, Thomas Zander wrote:
> > If you write a bugreport about this I might get to it and fix it myself. Its my \
> > component to maintain, afterall. I'd like this code to be free from \
> > maybe-this-works changes so I don't think this should be committed.
>
> Miroslav Nohaj wrote:
> But this 'one method call' fix _does_ work and was tested with two different \
> documents: one to see if your previous workaround (from svn revision 937897) still \
> solves the old issue and one to see if my workaround for your workaround solves the \
> new issue.
> The bug report is here: https://bugs.kde.org/show_bug.cgi?id=239685
>
> Thomas Zander wrote:
> A "maybe-this-works" change can indeed work just fine for your test document, I \
> didn't mean to say otherwise. It doesn't make the patch correct or consistent with \
> the rest of the code.
> The bugreport is good, its filed and needs to be investigated. Any findings you \
> have would be good to be added in details in the report as comments so someone else \
> can continue without duplicating work.
> As mentioned; this is a "maybe-this-works" change, so please close the review as \
> this should not be committed.
> Miroslav Nohaj wrote:
> OK, I'm closing it...
>
> Suresh Chande wrote:
> So what is the suggestion on how this issue is to be fixed ? We want this issue to \
> be fixed please advice the solution on this which you think is right if the \
> provided patch does not provide a right solution to the problem. I see the above \
> bug is assigned to yourself. So when will this bug be fixed ?
>
> Thomas Zander wrote:
> The suggestion on how this is fixed is that its an open bug just like the other 100 \
> on bugzilla and it will be fixed when it will be fixed. Bugs are prioritized based \
> on how many users it hits, how easy it is to avoid and what how much damage the bug \
> does to the users data.
No, Thomas, I'm afraid is not just like any of the open bugs. It's a bug he wants to \
get fixed. You prioritize the bugs you solve by how many users it affects; he \
prioritizes them differently. He suggested a way to solve it, you rejected it, now, \
in order for your rejection to be really well thought and valid, you must give a list \
of reasons and points to address in order for the fix to be committed. Only negative \
positions are to be avoided (it's wrong because…,) they should be complemented with \
positive positions (you can fix it by doing….)
- Carlos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4174/#review6723
-----------------------------------------------------------
On 2010-07-22 12:01:14, Miroslav Nohaj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4174/
> -----------------------------------------------------------
>
> (Updated 2010-07-22 12:01:14)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> When the .odt document contains only one paragraph which contains something (i.e. \
> image) that is bigger than one page, the layout tries to add one page to make it \
> fit, but as that larger thing won't be put on the first page, the situation repeats \
> and it tries to add another page, and so on...
> The patch checks if the next shapes (together) have enough space to hold the \
> current large thing and if they do, it will not try to add more pages. I know that \
> this might not the best solution so I'm awaiting some recommendations from Thomas \
> on what would be a better way to do it and as this patch will be probably remade, \
> it doesn't contain comments in the code.
>
> Diffs
> -----
>
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1134229
>
> Diff: http://reviewboard.kde.org/r/4174/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Miroslav
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4174/">http://reviewboard.kde.org/r/4174/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 28th, 2010, 11:21 a.m., <b>Thomas \
Zander</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If you write a bugreport about this I might get to it and fix it myself. \
Its my component to maintain, afterall. I'd like this code to be free from \
maybe-this-works changes so I don't think this should be committed.</pre> \
</blockquote>
<p>On July 28th, 2010, 11:56 a.m., <b>Miroslav Nohaj</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But this 'one method \
call' fix _does_ work and was tested with two different documents: one to see if \
your previous workaround (from svn revision 937897) still solves the old issue and \
one to see if my workaround for your workaround solves the new issue.
The bug report is here: https://bugs.kde.org/show_bug.cgi?id=239685</pre>
</blockquote>
<p>On July 28th, 2010, 12:24 p.m., <b>Thomas Zander</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A \
"maybe-this-works" change can indeed work just fine for your test document, \
I didn't mean to say otherwise. It doesn't make the patch correct or \
consistent with the rest of the code.
The bugreport is good, its filed and needs to be investigated. Any findings you have \
would be good to be added in details in the report as comments so someone else can \
continue without duplicating work.
As mentioned; this is a "maybe-this-works" change, so please close the \
review as this should not be committed.</pre> </blockquote>
<p>On July 28th, 2010, 12:27 p.m., <b>Miroslav Nohaj</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, I'm closing \
it... </pre> </blockquote>
<p>On August 10th, 2010, 7:02 p.m., <b>Suresh Chande</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So what is the \
suggestion on how this issue is to be fixed ? We want this issue to be fixed please \
advice the solution on this which you think is right if the provided patch does not \
provide a right solution to the problem. I see the above bug is assigned to yourself. \
So when will this bug be fixed ? </pre>
</blockquote>
<p>On August 11th, 2010, 9:03 a.m., <b>Thomas Zander</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The suggestion on how \
this is fixed is that its an open bug just like the other 100 on bugzilla and it will \
be fixed when it will be fixed. Bugs are prioritized based on how many users it hits, \
how easy it is to avoid and what how much damage the bug does to the users \
data.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No, Thomas, I'm \
afraid is not just like any of the open bugs. It's a bug he wants to get fixed. \
You prioritize the bugs you solve by how many users it affects; he prioritizes them \
differently. He suggested a way to solve it, you rejected it, now, in order for your \
rejection to be really well thought and valid, you must give a list of reasons and \
points to address in order for the fix to be committed. Only negative positions are \
to be avoided (it's wrong because…,) they should be complemented with positive \
positions (you can fix it by doing….)</pre> <br />
<p>- Carlos</p>
<br />
<p>On July 22nd, 2010, 12:01 p.m., Miroslav Nohaj wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Miroslav Nohaj.</div>
<p style="color: grey;"><i>Updated 2010-07-22 12:01:14</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the .odt document contains only one paragraph which contains \
something (i.e. image) that is bigger than one page, the layout tries to add one page \
to make it fit, but as that larger thing won't be put on the first page, the \
situation repeats and it tries to add another page, and so on...
The patch checks if the next shapes (together) have enough space to hold the current \
large thing and if they do, it will not try to add more pages. I know that this might \
not the best solution so I'm awaiting some recommendations from Thomas on what \
would be a better way to do it and as this patch will be probably remade, it \
doesn't contain comments in the code. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp <span style="color: \
grey">(1134229)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4174/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic