'Re: Review Request: Switch from using QXmlReader to using'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Switch from using QXmlReader to using
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-08-10 18:43:50
Message-ID: 20100810184350.2056.92916 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4967/#review6977
-----------------------------------------------------------

Any data on what it does to the memory consumption while loading documents?

- Boudewijn

On 2010-08-10 18:35:05, vandenoever wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4967/
> -----------------------------------------------------------
> =

> (Updated 2010-08-10 18:35:05)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> Switch from using QXmlReader to using QXmlStreamReader. This simple port =
gives a speedup of 5% on a document with a lot of text. Quite a few more op=
timizations are possible now by taking advantage of QStringRef.
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp 1161556 =

>   trunk/koffice/filters/liboofilter/ooutils.cc 1161556 =

>   trunk/koffice/libs/odf/KoOdfReadStore.h 1161556 =

>   trunk/koffice/libs/odf/KoOdfReadStore.cpp 1161556 =

>   trunk/koffice/libs/odf/KoXmlReader.h 1161556 =

>   trunk/koffice/libs/odf/KoXmlReader.cpp 1161556 =

>   trunk/koffice/libs/odf/tests/TestXmlReader.cpp 1161556 =

> =

> Diff: http://reviewboard.kde.org/r/4967/diff
> =

> =

> Testing
> -------
> =

> TestXmlReader passes fine.
> =

> =

> Thanks,
> =

> vandenoever
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4967/">http://reviewboard.kde.org/r/4967/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any data on what it does \
to the memory consumption while loading documents?</pre>  <br />

<p>- Boudewijn</p>

<br />
<p>On August 10th, 2010, 6:35 p.m., vandenoever wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By vandenoever.</div>

<p style="color: grey;"><i>Updated 2010-08-10 18:35:05</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Switch from using QXmlReader to using QXmlStreamReader. This simple port \
gives a speedup of 5% on a document with a lot of text. Quite a few more \
optimizations are possible now by taking advantage of QStringRef.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">TestXmlReader passes fine. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/filters/libmsooxml/MsooXmlUtils.cpp <span style="color: \
grey">(1161556)</span></li>

 <li>trunk/koffice/filters/liboofilter/ooutils.cc <span style="color: \
grey">(1161556)</span></li>

 <li>trunk/koffice/libs/odf/KoOdfReadStore.h <span style="color: \
grey">(1161556)</span></li>

 <li>trunk/koffice/libs/odf/KoOdfReadStore.cpp <span style="color: \
grey">(1161556)</span></li>

 <li>trunk/koffice/libs/odf/KoXmlReader.h <span style="color: \
grey">(1161556)</span></li>

 <li>trunk/koffice/libs/odf/KoXmlReader.cpp <span style="color: \
grey">(1161556)</span></li>

 <li>trunk/koffice/libs/odf/tests/TestXmlReader.cpp <span style="color: \
grey">(1161556)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4967/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 